Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(47)

Side by Side Diff: third_party/WebKit/Source/modules/fetch/BodyStreamBuffer.cpp

Issue 2366253002: Remove ActiveDOMObject::stop() (Closed)
Patch Set: temp Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "modules/fetch/BodyStreamBuffer.h" 5 #include "modules/fetch/BodyStreamBuffer.h"
6 6
7 #include "bindings/core/v8/ScriptState.h" 7 #include "bindings/core/v8/ScriptState.h"
8 #include "bindings/core/v8/V8HiddenValue.h" 8 #include "bindings/core/v8/V8HiddenValue.h"
9 #include "core/dom/DOMArrayBuffer.h" 9 #include "core/dom/DOMArrayBuffer.h"
10 #include "core/dom/DOMTypedArray.h" 10 #include "core/dom/DOMTypedArray.h"
(...skipping 50 matching lines...) Expand 10 before | Expand all | Expand 10 after
61 } 61 }
62 62
63 DEFINE_INLINE_TRACE() { 63 DEFINE_INLINE_TRACE() {
64 visitor->trace(m_buffer); 64 visitor->trace(m_buffer);
65 visitor->trace(m_client); 65 visitor->trace(m_client);
66 ActiveDOMObject::trace(visitor); 66 ActiveDOMObject::trace(visitor);
67 FetchDataLoader::Client::trace(visitor); 67 FetchDataLoader::Client::trace(visitor);
68 } 68 }
69 69
70 private: 70 private:
71 void stop() override { m_buffer->stopLoading(); } 71 void contextDestroyed() override { m_buffer->stopLoading(); }
72 72
73 Member<BodyStreamBuffer> m_buffer; 73 Member<BodyStreamBuffer> m_buffer;
74 Member<FetchDataLoader::Client> m_client; 74 Member<FetchDataLoader::Client> m_client;
75 }; 75 };
76 76
77 BodyStreamBuffer::BodyStreamBuffer(ScriptState* scriptState, 77 BodyStreamBuffer::BodyStreamBuffer(ScriptState* scriptState,
78 BytesConsumer* consumer) 78 BytesConsumer* consumer)
79 : UnderlyingSourceBase(scriptState), 79 : UnderlyingSourceBase(scriptState),
80 m_scriptState(scriptState), 80 m_scriptState(scriptState),
81 m_consumer(consumer), 81 m_consumer(consumer),
(...skipping 146 matching lines...) Expand 10 before | Expand all | Expand 10 after
228 } 228 }
229 processData(); 229 processData();
230 } 230 }
231 231
232 bool BodyStreamBuffer::hasPendingActivity() const { 232 bool BodyStreamBuffer::hasPendingActivity() const {
233 if (m_loader) 233 if (m_loader)
234 return true; 234 return true;
235 return UnderlyingSourceBase::hasPendingActivity(); 235 return UnderlyingSourceBase::hasPendingActivity();
236 } 236 }
237 237
238 void BodyStreamBuffer::stop() { 238 void BodyStreamBuffer::contextDestroyed() {
239 cancelConsumer(); 239 cancelConsumer();
240 UnderlyingSourceBase::stop(); 240 UnderlyingSourceBase::contextDestroyed();
241 } 241 }
242 242
243 bool BodyStreamBuffer::isStreamReadable() { 243 bool BodyStreamBuffer::isStreamReadable() {
244 ScriptState::Scope scope(m_scriptState.get()); 244 ScriptState::Scope scope(m_scriptState.get());
245 return ReadableStreamOperations::isReadable(m_scriptState.get(), stream()); 245 return ReadableStreamOperations::isReadable(m_scriptState.get(), stream());
246 } 246 }
247 247
248 bool BodyStreamBuffer::isStreamClosed() { 248 bool BodyStreamBuffer::isStreamClosed() {
249 ScriptState::Scope scope(m_scriptState.get()); 249 ScriptState::Scope scope(m_scriptState.get());
250 return ReadableStreamOperations::isClosed(m_scriptState.get(), stream()); 250 return ReadableStreamOperations::isClosed(m_scriptState.get(), stream());
(...skipping 128 matching lines...) Expand 10 before | Expand all | Expand 10 after
379 } 379 }
380 if (isErrored) 380 if (isErrored)
381 return BytesConsumer::createErrored(BytesConsumer::Error("error")); 381 return BytesConsumer::createErrored(BytesConsumer::Error("error"));
382 382
383 DCHECK(consumer); 383 DCHECK(consumer);
384 consumer->clearClient(); 384 consumer->clearClient();
385 return consumer; 385 return consumer;
386 } 386 }
387 387
388 } // namespace blink 388 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698