Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(916)

Side by Side Diff: third_party/WebKit/Source/core/streams/UnderlyingSourceBase.cpp

Issue 2366253002: Remove ActiveDOMObject::stop() (Closed)
Patch Set: temp Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "core/streams/UnderlyingSourceBase.h" 5 #include "core/streams/UnderlyingSourceBase.h"
6 6
7 #include "bindings/core/v8/ScriptPromise.h" 7 #include "bindings/core/v8/ScriptPromise.h"
8 #include "bindings/core/v8/ScriptState.h" 8 #include "bindings/core/v8/ScriptState.h"
9 #include "bindings/core/v8/ScriptValue.h" 9 #include "bindings/core/v8/ScriptValue.h"
10 #include "core/streams/ReadableStreamController.h" 10 #include "core/streams/ReadableStreamController.h"
(...skipping 39 matching lines...) Expand 10 before | Expand all | Expand 10 after
50 } 50 }
51 51
52 bool UnderlyingSourceBase::hasPendingActivity() const { 52 bool UnderlyingSourceBase::hasPendingActivity() const {
53 // This will return false within a finite time period _assuming_ that 53 // This will return false within a finite time period _assuming_ that
54 // consumers use the controller to close or error the stream. 54 // consumers use the controller to close or error the stream.
55 // Browser-created readable streams should always close or error within a 55 // Browser-created readable streams should always close or error within a
56 // finite time period, due to timeouts etc. 56 // finite time period, due to timeouts etc.
57 return m_controller && m_controller->isActive() && m_isStreamLocked; 57 return m_controller && m_controller->isActive() && m_isStreamLocked;
58 } 58 }
59 59
60 void UnderlyingSourceBase::stop() { 60 void UnderlyingSourceBase::contextDestroyed() {
61 if (m_controller) { 61 if (m_controller) {
62 m_controller->noteHasBeenCanceled(); 62 m_controller->noteHasBeenCanceled();
63 m_controller.clear(); 63 m_controller.clear();
64 } 64 }
65 } 65 }
66 66
67 DEFINE_TRACE(UnderlyingSourceBase) { 67 DEFINE_TRACE(UnderlyingSourceBase) {
68 ActiveDOMObject::trace(visitor); 68 ActiveDOMObject::trace(visitor);
69 visitor->trace(m_controller); 69 visitor->trace(m_controller);
70 } 70 }
71 71
72 } // namespace blink 72 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698