Remove ActiveDOMObject::stop()

third_party/WebKit/Source/core/dom/Document.cpp

 /*
  * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
  *           (C) 1999 Antti Koivisto (koivisto@kde.org)
  *           (C) 2001 Dirk Mueller (mueller@kde.org)
  *           (C) 2006 Alexey Proskuryakov (ap@webkit.org)
  * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2011, 2012 Apple Inc. All
  * rights reserved.
  * Copyright (C) 2008, 2009 Torch Mobile Inc. All rights reserved.
  * (http://www.torchmobile.com/)
  * Copyright (C) 2008, 2009, 2011, 2012 Google Inc. All rights reserved.
@@ skipping 2264 matching lines @@
   // to trigger navigation here.  However, plugins (see below) can cause lots of
   // crazy things to happen, since plugin detach involves nested message loops.
   FrameNavigationDisabler navigationDisabler(*m_frame);
   // Defer widget updates to avoid plugins trying to run script inside
   // ScriptForbiddenScope, which will crash the renderer after
   // https://crrev.com/200984
   HTMLFrameOwnerElement::UpdateSuspendScope suspendWidgetHierarchyUpdates;
   // Don't allow script to run in the middle of detachLayoutTree() because a
   // detaching Document is not in a consistent state.
   ScriptForbiddenScope forbidScript;
+
   view()->dispose();
   m_markers->prepareForDestruction();
 
   m_lifecycle.advanceTo(DocumentLifecycle::Stopping);
 
   if (page())
     page()->documentDetached(this);
   InspectorInstrumentation::documentDetached(this);
 
   if (m_frame->loader().client()->sharedWorkerRepositoryClient())
     m_frame->loader()
         .client()
         ->sharedWorkerRepositoryClient()
         ->documentDetached(this);
 
-  stopActiveDOMObjects();
-
   // FIXME: consider using ActiveDOMObject.
   if (m_scriptedAnimationController)
     m_scriptedAnimationController->clearDocumentPointer();
   m_scriptedAnimationController.clear();
 
   m_scriptedIdleTaskController.clear();
 
   if (svgExtensions())
     accessSVGExtensions().pauseAnimations();
 
@@ skipping 65 matching lines @@
                                   ->currentThread()
                                   ->scheduler()
                                   ->timerTaskRunner()
                                   ->clone());
 
   if (m_mediaQueryMatcher)
     m_mediaQueryMatcher->documentDetached();
 
   m_lifecycle.advanceTo(DocumentLifecycle::Stopped);
 
-  // FIXME: Currently we call notifyContextDestroyed() only in
+  // TODO(haraken): Call contextDestroyed() before we start any disruptive
+  // operations.
+  // TODO(haraken): Currently we call notifyContextDestroyed() only in
   // Document::detachLayoutTree(), which means that we don't call
   // notifyContextDestroyed() for a document that doesn't get detached.
   // If such a document has any observer, the observer won't get
   // a contextDestroyed() notification. This can happen for a document
   // created by DOMImplementation::createDocument().
   ExecutionContext::notifyContextDestroyed();
 
-  // This is required, as our LocalFrame might delete itself as soon as it
-  // detaches us. However, this violates Node::detachLayoutTree() semantics, as
-  // it's never possible to re-attach. Eventually Document::detachLayoutTree()
-  // should be renamed, or this setting of the frame to 0 could be made explicit
-  // in each of the callers of Document::detachLayoutTree().
+  // This is required, as our LocalFrame might delete itself as soon as it detaches
+  // us. However, this violates Node::detachLayoutTree() semantics, as it's never
+  // possible to re-attach. Eventually Document::detachLayoutTree() should be renamed,
+  // or this setting of the frame to 0 could be made explicit in each of the
+  // callers of Document::detachLayoutTree().
   m_frame = nullptr;
 }
 
 void Document::removeAllEventListeners() {
   ContainerNode::removeAllEventListeners();
 
   if (LocalDOMWindow* domWindow = this->domWindow())
     domWindow->removeAllEventListeners();
 }
 
@@ skipping 3959 matching lines @@
 }
 
 void showLiveDocumentInstances() {
   WeakDocumentSet& set = liveDocumentSet();
   fprintf(stderr, "There are %u documents currently alive:\n", set.size());
   for (Document* document : set)
     fprintf(stderr, "- Document %p URL: %s\n", document,
             document->url().getString().utf8().data());
 }
 #endif