Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(937)

Issue 2366223002: Prune CreateVisiblePositionDeprecated from adjustedSelectionStartForStyleComputation (Closed)

Created:
4 years, 2 months ago by Xiaocheng
Modified:
4 years, 2 months ago
Reviewers:
yosin_UTC9
CC:
blink-reviews, blink-reviews-style_chromium.org, chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Prune CreateVisiblePositionDeprecated from adjustedSelectionStartForStyleComputation BUG=647219 Committed: https://crrev.com/b1748ff3d863efb0fe68743e4b710ed421add950 Cr-Commit-Position: refs/heads/master@{#421061}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -1 line) Patch
M third_party/WebKit/Source/core/editing/EditingStyle.cpp View 1 chunk +8 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/editing/EditingUtilities.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 16 (11 generated)
Xiaocheng
PTAL.
4 years, 2 months ago (2016-09-26 03:35:54 UTC) #4
yosin_UTC9
lgtm
4 years, 2 months ago (2016-09-26 04:46:36 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2366223002/1
4 years, 2 months ago (2016-09-26 23:40:25 UTC) #13
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-09-27 01:01:05 UTC) #14
commit-bot: I haz the power
4 years, 2 months ago (2016-09-27 01:04:47 UTC) #16
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b1748ff3d863efb0fe68743e4b710ed421add950
Cr-Commit-Position: refs/heads/master@{#421061}

Powered by Google App Engine
This is Rietveld 408576698