OLD | NEW |
1 # Copyright (c) 2013 The Chromium Authors. All rights reserved. | 1 # Copyright (c) 2013 The Chromium Authors. All rights reserved. |
2 # Use of this source code is governed by a BSD-style license that can be | 2 # Use of this source code is governed by a BSD-style license that can be |
3 # found in the LICENSE file. | 3 # found in the LICENSE file. |
4 | 4 |
5 """Top-level presubmit script for Blink. | 5 """Top-level presubmit script for Blink. |
6 | 6 |
7 See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts | 7 See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts |
8 for more details about the presubmit API built into gcl. | 8 for more details about the presubmit API built into gcl. |
9 """ | 9 """ |
10 | 10 |
(...skipping 80 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... |
91 | 91 |
92 def _CommonChecks(input_api, output_api): | 92 def _CommonChecks(input_api, output_api): |
93 """Checks common to both upload and commit.""" | 93 """Checks common to both upload and commit.""" |
94 # We should figure out what license checks we actually want to use. | 94 # We should figure out what license checks we actually want to use. |
95 license_header = r'.*' | 95 license_header = r'.*' |
96 | 96 |
97 results = [] | 97 results = [] |
98 results.extend(input_api.canned_checks.PanProjectChecks( | 98 results.extend(input_api.canned_checks.PanProjectChecks( |
99 input_api, output_api, excluded_paths=_EXCLUDED_PATHS, | 99 input_api, output_api, excluded_paths=_EXCLUDED_PATHS, |
100 maxlen=800, license_header=license_header)) | 100 maxlen=800, license_header=license_header)) |
| 101 results.extend(input_api.canned_checks.CheckPatchFormatted(input_api, output
_api)) |
101 results.extend(_CheckForNonBlinkVariantMojomIncludes(input_api, output_api)) | 102 results.extend(_CheckForNonBlinkVariantMojomIncludes(input_api, output_api)) |
102 results.extend(_CheckForVersionControlConflicts(input_api, output_api)) | 103 results.extend(_CheckForVersionControlConflicts(input_api, output_api)) |
103 results.extend(_CheckPatchFiles(input_api, output_api)) | 104 results.extend(_CheckPatchFiles(input_api, output_api)) |
104 results.extend(_CheckTestExpectations(input_api, output_api)) | 105 results.extend(_CheckTestExpectations(input_api, output_api)) |
105 results.extend(_CheckChromiumPlatformMacros(input_api, output_api)) | 106 results.extend(_CheckChromiumPlatformMacros(input_api, output_api)) |
106 results.extend(_CheckWatchlist(input_api, output_api)) | 107 results.extend(_CheckWatchlist(input_api, output_api)) |
107 results.extend(_CheckFilePermissions(input_api, output_api)) | 108 results.extend(_CheckFilePermissions(input_api, output_api)) |
108 return results | 109 return results |
109 | 110 |
110 | 111 |
(...skipping 264 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... |
375 new_description = description | 376 new_description = description |
376 new_description += '\nCQ_INCLUDE_TRYBOTS=%s' % ';'.join(bots) | 377 new_description += '\nCQ_INCLUDE_TRYBOTS=%s' % ';'.join(bots) |
377 results.append(output_api.PresubmitNotifyResult( | 378 results.append(output_api.PresubmitNotifyResult( |
378 'Automatically added slimming-paint-v2 tests to run on CQ due to ' | 379 'Automatically added slimming-paint-v2 tests to run on CQ due to ' |
379 'changes in paint or compositing directories.')) | 380 'changes in paint or compositing directories.')) |
380 | 381 |
381 if new_description != description: | 382 if new_description != description: |
382 rietveld_obj.update_description(issue, new_description) | 383 rietveld_obj.update_description(issue, new_description) |
383 | 384 |
384 return results | 385 return results |
OLD | NEW |