OLD | NEW |
1 # Copyright (c) 2013 The Chromium Authors. All rights reserved. | 1 # Copyright (c) 2013 The Chromium Authors. All rights reserved. |
2 # Use of this source code is governed by a BSD-style license that can be | 2 # Use of this source code is governed by a BSD-style license that can be |
3 # found in the LICENSE file. | 3 # found in the LICENSE file. |
4 | 4 |
5 """Top-level presubmit script for Blink. | 5 """Top-level presubmit script for Blink. |
6 | 6 |
7 See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts | 7 See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts |
8 for more details about the presubmit API built into gcl. | 8 for more details about the presubmit API built into gcl. |
9 """ | 9 """ |
10 | 10 |
(...skipping 76 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... |
87 | 87 |
88 def _CommonChecks(input_api, output_api): | 88 def _CommonChecks(input_api, output_api): |
89 """Checks common to both upload and commit.""" | 89 """Checks common to both upload and commit.""" |
90 # We should figure out what license checks we actually want to use. | 90 # We should figure out what license checks we actually want to use. |
91 license_header = r'.*' | 91 license_header = r'.*' |
92 | 92 |
93 results = [] | 93 results = [] |
94 results.extend(input_api.canned_checks.PanProjectChecks( | 94 results.extend(input_api.canned_checks.PanProjectChecks( |
95 input_api, output_api, excluded_paths=_EXCLUDED_PATHS, | 95 input_api, output_api, excluded_paths=_EXCLUDED_PATHS, |
96 maxlen=800, license_header=license_header)) | 96 maxlen=800, license_header=license_header)) |
| 97 results.extend(input_api.canned_checks.CheckPatchFormatted(input_api, output
_api)) |
97 results.extend(_CheckForNonBlinkVariantMojomIncludes(input_api, output_api)) | 98 results.extend(_CheckForNonBlinkVariantMojomIncludes(input_api, output_api)) |
98 results.extend(_CheckForVersionControlConflicts(input_api, output_api)) | 99 results.extend(_CheckForVersionControlConflicts(input_api, output_api)) |
99 results.extend(_CheckPatchFiles(input_api, output_api)) | 100 results.extend(_CheckPatchFiles(input_api, output_api)) |
100 results.extend(_CheckTestExpectations(input_api, output_api)) | 101 results.extend(_CheckTestExpectations(input_api, output_api)) |
101 results.extend(_CheckChromiumPlatformMacros(input_api, output_api)) | 102 results.extend(_CheckChromiumPlatformMacros(input_api, output_api)) |
102 results.extend(_CheckWatchlist(input_api, output_api)) | 103 results.extend(_CheckWatchlist(input_api, output_api)) |
103 results.extend(_CheckFilePermissions(input_api, output_api)) | 104 results.extend(_CheckFilePermissions(input_api, output_api)) |
104 return results | 105 return results |
105 | 106 |
106 | 107 |
(...skipping 264 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... |
371 new_description = description | 372 new_description = description |
372 new_description += '\nCQ_INCLUDE_TRYBOTS=%s' % ';'.join(bots) | 373 new_description += '\nCQ_INCLUDE_TRYBOTS=%s' % ';'.join(bots) |
373 results.append(output_api.PresubmitNotifyResult( | 374 results.append(output_api.PresubmitNotifyResult( |
374 'Automatically added slimming-paint-v2 tests to run on CQ due to ' | 375 'Automatically added slimming-paint-v2 tests to run on CQ due to ' |
375 'changes in paint or compositing directories.')) | 376 'changes in paint or compositing directories.')) |
376 | 377 |
377 if new_description != description: | 378 if new_description != description: |
378 rietveld_obj.update_description(issue, new_description) | 379 rietveld_obj.update_description(issue, new_description) |
379 | 380 |
380 return results | 381 return results |
OLD | NEW |