core/fpdfapi/fpdf_font/fpdf_font_cid.cpp - Issue 2366143002: Fix memory leak in cmap parsing

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: core/fpdfapi/fpdf_font/fpdf_font_cid.cpp

Issue 2366143002: Fix memory leak in cmap parsing (Closed)

Patch Set: Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: core/fpdfapi/fpdf_font/fpdf_font_cid.cpp

diff --git a/core/fpdfapi/fpdf_font/fpdf_font_cid.cpp b/core/fpdfapi/fpdf_font/fpdf_font_cid.cpp

index f3c5f05d51ec071ca469de5e427024d3bdd02242..93d29d9bc70da61855185ff237a499a8049d851d 100644

--- a/core/fpdfapi/fpdf_font/fpdf_font_cid.cpp

+++ b/core/fpdfapi/fpdf_font/fpdf_font_cid.cpp

@@ -413,6 +413,7 @@ void CPDF_CMapParser::ParseWord(const CFX_ByteStringC& word) {

if (nSegs > 1) {

m_pCMap->m_CodingScheme = CPDF_CMap::MixedFourBytes;

m_pCMap->m_nCodeRanges = nSegs;

+ FX_Free(m_pCMap->m_pLeadingBytes);

m_pCMap->m_pLeadingBytes =

FX_Alloc2D(uint8_t, nSegs, sizeof(CMap_CodeRange));

FXSYS_memcpy(m_pCMap->m_pLeadingBytes, m_CodeRanges.GetData(),

« no previous file with comments | « no previous file | no next file » | no next file with comments »