[PDF viewer] Align page N of M input field

[PDF viewer] Align page N of M input field

This CL sets the alignment of the N part of the: page N / M at the top
of the PDF viewer. The N was rendering too high and this change brings
it down to the baseline with the " / M" part of the line.

BUG=648116
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/d2752a183c0b1bc7c6ed6bdca17ac5d8eccf8b96
Cr-Commit-Position: refs/heads/master@{#421376}

[dschuyler, 2016-09-24 01:47:36]

Description was changed from

==========
[PDF viewer] Align page N of M input field

This CL sets the alignment of the N part of the: page N / M at the top
of the PDF viewer. The N was rendering too high and this change brings
it down to the baseline with the " / M" part of the line.

BUG=648116
==========

to

==========
[PDF viewer] Align page N of M input field

This CL sets the alignment of the N part of the: page N / M at the top
of the PDF viewer. The N was rendering too high and this change brings
it down to the baseline with the " / M" part of the line.

BUG=648116
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[dschuyler, 2016-09-24 01:47:38]

The CQ bit was checked by dschuyler@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-24 01:47:53]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dschuyler, 2016-09-24 01:48:15]

dschuyler@chromium.org changed reviewers:
+ thestig@chromium.org

[Lei Zhang, 2016-09-24 02:41:59]

thestig@chromium.org changed reviewers:
+ dbeam@chromium.org

[Dan Beam, 2016-09-24 02:45:37]

tsergeant@ or raymes@ are better reviewers for PDF polymer-y things

[commit-bot: I haz the power, 2016-09-24 02:46:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-24 02:46:03]

Dry run: This issue passed the CQ dry run.

[raymes, 2016-09-25 23:45:11]

raymes@chromium.org changed reviewers:
+ raymes@chromium.org, tsergeant@chromium.org

[raymes, 2016-09-25 23:45:12]

tsergeant@ is best.

[tsergeant, 2016-09-26 00:06:19]

https://codereview.chromium.org/2366113002/diff/1/chrome/browser/resources/pd...
File
chrome/browser/resources/pdf/elements/viewer-page-selector/viewer-page-selector.css
(right):

https://codereview.chromium.org/2366113002/diff/1/chrome/browser/resources/pd...
chrome/browser/resources/pdf/elements/viewer-page-selector/viewer-page-selector.css:27:
--paper-input-container-input: {
#input is the <input>, #pageselector is the <paper-input-container>, so the
mixin belongs in the block above rather than here.

You could also get rid of the mixin and do `vertical-align: baseline` in this
block directly, which would simplify things a bit.

[dschuyler, 2016-09-27 19:25:39]

The CQ bit was checked by dschuyler@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-27 19:26:10]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-27 20:38:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-27 20:38:34]

Dry run: This issue passed the CQ dry run.

[dschuyler, 2016-09-27 20:45:21]

dschuyler@chromium.org changed reviewers:
- dbeam@chromium.org, raymes@chromium.org, thestig@chromium.org

[dschuyler, 2016-09-27 20:45:22]

Reduced interviewers to just tsergeant@.

https://codereview.chromium.org/2366113002/diff/1/chrome/browser/resources/pd...
File
chrome/browser/resources/pdf/elements/viewer-page-selector/viewer-page-selector.css
(right):

https://codereview.chromium.org/2366113002/diff/1/chrome/browser/resources/pd...
chrome/browser/resources/pdf/elements/viewer-page-selector/viewer-page-selector.css:27:
--paper-input-container-input: {
On 2016/09/26 00:06:19, tsergeant wrote:
> #input is the <input>, #pageselector is the <paper-input-container>, so the
> mixin belongs in the block above rather than here.
> 
> You could also get rid of the mixin and do `vertical-align: baseline` in this
> block directly, which would simplify things a bit.

Done.

[tsergeant, 2016-09-27 22:40:08]

non-owner lgtm

[Lei Zhang, 2016-09-27 22:40:44]

thestig@chromium.org changed reviewers:
+ thestig@chromium.org

[Lei Zhang, 2016-09-27 22:40:45]

rs lgtm

[dschuyler, 2016-09-27 22:59:26]

The CQ bit was checked by dschuyler@chromium.org

[commit-bot: I haz the power, 2016-09-27 22:59:54]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-27 23:05:10]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-09-27 23:08:23]

Description was changed from

==========
[PDF viewer] Align page N of M input field

This CL sets the alignment of the N part of the: page N / M at the top
of the PDF viewer. The N was rendering too high and this change brings
it down to the baseline with the " / M" part of the line.

BUG=648116
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
[PDF viewer] Align page N of M input field

This CL sets the alignment of the N part of the: page N / M at the top
of the PDF viewer. The N was rendering too high and this change brings
it down to the baseline with the " / M" part of the line.

BUG=648116
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/d2752a183c0b1bc7c6ed6bdca17ac5d8eccf8b96
Cr-Commit-Position: refs/heads/master@{#421376}
==========

[commit-bot: I haz the power, 2016-09-27 23:08:24]

Patchset 2 (id:??) landed as
https://crrev.com/d2752a183c0b1bc7c6ed6bdca17ac5d8eccf8b96
Cr-Commit-Position: refs/heads/master@{#421376}