Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(293)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 23661005: [NaCl SDK] Add a very simple getting_started example at top-level. (Closed)

Created:
7 years, 3 months ago by binji
Modified:
7 years, 3 months ago
Reviewers:
noelallen1, eliben
CC:
chromium-reviews, Sam Clegg
Visibility:
Public.

Description

[NaCl SDK] Add a very simple getting_started example at top-level. * Added getting_started/ parallel to examples/ * Added getting_started/part1/ which is a quick port of hello_tutorial from the NaCl SDK documentation page. * Added support for examples not using auto-generated Makefiles * Disbled testing of getting_started/part1 (it doesn't have the test hooks) * Moved examples/getting_started/simple_hello_world => examples/tutorial/using_ppapi_simple BUG=none R=eliben@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=222142

Patch Set 1 #

Total comments: 20

Patch Set 2 : fixes #

Total comments: 4

Patch Set 3 : nit #

Patch Set 4 : added getting_started/README #

Patch Set 5 : Add hello_tutorial.nmf #

Unified diffs Side-by-side diffs Delta from patch set Stats (+358 lines, -404 lines) Patch
M native_client_sdk/src/build_tools/build_sdk.py View 1 chunk +1 line, -1 line 0 comments Download
M native_client_sdk/src/build_tools/generate_make.py View 3 chunks +13 lines, -4 lines 0 comments Download
M native_client_sdk/src/build_tools/parse_dsc.py View 2 chunks +2 lines, -2 lines 0 comments Download
M native_client_sdk/src/build_tools/sdk_files.list View 4 chunks +25 lines, -25 lines 0 comments Download
M native_client_sdk/src/build_tools/test_projects.py View 1 chunk +5 lines, -0 lines 0 comments Download
M native_client_sdk/src/build_tools/test_sdk.py View 1 chunk +4 lines, -0 lines 0 comments Download
D native_client_sdk/src/examples/getting_started/hello_world/example.dsc View 1 chunk +0 lines, -18 lines 0 comments Download
D native_client_sdk/src/examples/getting_started/hello_world/example.js View 1 chunk +0 lines, -13 lines 0 comments Download
D native_client_sdk/src/examples/getting_started/hello_world/hello_world.c View 1 chunk +0 lines, -212 lines 0 comments Download
D native_client_sdk/src/examples/getting_started/hello_world/index.html View 1 chunk +0 lines, -29 lines 0 comments Download
D native_client_sdk/src/examples/getting_started/simple_hello_world/example.dsc View 1 chunk +0 lines, -21 lines 0 comments Download
D native_client_sdk/src/examples/getting_started/simple_hello_world/example.js View 1 chunk +0 lines, -13 lines 0 comments Download
D native_client_sdk/src/examples/getting_started/simple_hello_world/hello_world.c View 1 chunk +0 lines, -28 lines 0 comments Download
D native_client_sdk/src/examples/getting_started/simple_hello_world/index.html View 1 chunk +0 lines, -33 lines 0 comments Download
A + native_client_sdk/src/examples/tutorial/using_ppapi_simple/example.dsc View 2 chunks +5 lines, -6 lines 0 comments Download
A + native_client_sdk/src/examples/tutorial/using_ppapi_simple/example.js View 0 chunks +-1 lines, --1 lines 0 comments Download
A + native_client_sdk/src/examples/tutorial/using_ppapi_simple/hello_world.c View 0 chunks +-1 lines, --1 lines 0 comments Download
A + native_client_sdk/src/examples/tutorial/using_ppapi_simple/index.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A native_client_sdk/src/getting_started/README View 1 2 3 1 chunk +7 lines, -0 lines 0 comments Download
A native_client_sdk/src/getting_started/part1/Makefile View 1 2 1 chunk +94 lines, -0 lines 0 comments Download
A native_client_sdk/src/getting_started/part1/example.dsc View 1 chunk +13 lines, -0 lines 0 comments Download
A native_client_sdk/src/getting_started/part1/hello_tutorial.cc View 1 1 chunk +89 lines, -0 lines 0 comments Download
A + native_client_sdk/src/getting_started/part1/hello_tutorial.nmf View 1 2 3 4 1 chunk +1 line, -2 lines 0 comments Download
A native_client_sdk/src/getting_started/part1/index.html View 1 1 chunk +102 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
binji
7 years, 3 months ago (2013-09-06 23:55:35 UTC) #1
noelallen1
hello_tutorial.html + index.html in the same place is a bit confusing. Maybe we should put ...
7 years, 3 months ago (2013-09-09 04:32:00 UTC) #2
eliben
https://codereview.chromium.org/23661005/diff/1/native_client_sdk/src/getting_started/part1/Makefile File native_client_sdk/src/getting_started/part1/Makefile (right): https://codereview.chromium.org/23661005/diff/1/native_client_sdk/src/getting_started/part1/Makefile#newcode1 native_client_sdk/src/getting_started/part1/Makefile:1: # Copyright (c) 2012 The Native Client Authors. All ...
7 years, 3 months ago (2013-09-09 16:48:31 UTC) #3
binji
https://codereview.chromium.org/23661005/diff/1/native_client_sdk/src/getting_started/part1/Makefile File native_client_sdk/src/getting_started/part1/Makefile (right): https://codereview.chromium.org/23661005/diff/1/native_client_sdk/src/getting_started/part1/Makefile#newcode1 native_client_sdk/src/getting_started/part1/Makefile:1: # Copyright (c) 2012 The Native Client Authors. All ...
7 years, 3 months ago (2013-09-09 18:43:46 UTC) #4
eliben
LGTM [just some minor nits] https://codereview.chromium.org/23661005/diff/17001/native_client_sdk/src/getting_started/part1/Makefile File native_client_sdk/src/getting_started/part1/Makefile (right): https://codereview.chromium.org/23661005/diff/17001/native_client_sdk/src/getting_started/part1/Makefile#newcode25 native_client_sdk/src/getting_started/part1/Makefile:25: GETOS :=python $(NACL_SDK_ROOT)/tools/getos.py This ...
7 years, 3 months ago (2013-09-09 19:10:52 UTC) #5
noelallen1
WRT earlier comments on double hosting... We want to think about the user experience following ...
7 years, 3 months ago (2013-09-09 19:17:59 UTC) #6
eliben
On 2013/09/09 19:17:59, noelallen1 wrote: > WRT earlier comments on double hosting... > > We ...
7 years, 3 months ago (2013-09-09 19:20:21 UTC) #7
binji
https://codereview.chromium.org/23661005/diff/17001/native_client_sdk/src/getting_started/part1/Makefile File native_client_sdk/src/getting_started/part1/Makefile (right): https://codereview.chromium.org/23661005/diff/17001/native_client_sdk/src/getting_started/part1/Makefile#newcode25 native_client_sdk/src/getting_started/part1/Makefile:25: GETOS :=python $(NACL_SDK_ROOT)/tools/getos.py On 2013/09/09 19:10:53, eliben wrote: > ...
7 years, 3 months ago (2013-09-09 20:59:04 UTC) #8
binji
On 2013/09/09 19:20:21, eliben wrote: > On 2013/09/09 19:17:59, noelallen1 wrote: > > WRT earlier ...
7 years, 3 months ago (2013-09-09 21:08:03 UTC) #9
binji
7 years, 3 months ago (2013-09-10 00:10:23 UTC) #10
Message was sent while issue was closed. 
Committed patchset #5 manually as r222142 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698