Issue 23661004: add isolate parameter for Execution::Call

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 23661004: add isolate parameter for Execution::Call (Closed)

Created:
7 years, 3 months ago by dcarney

Modified:
7 years, 3 months ago

Reviewers:
Sven Panne

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+117 lines, -81 lines)			Patch
M	src/api.cc	View	1	5 chunks	+10 lines, -10 lines	0 comments	Download
M	src/bootstrapper.cc	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	src/builtins.cc	View	1	1 chunk	+2 lines, -1 line	0 comments	Download
M	src/debug.cc	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
M	src/execution.h	View		1 chunk	+2 lines, -1 line	0 comments	Download
M	src/execution.cc	View	1	6 chunks	+10 lines, -6 lines	0 comments	Download
M	src/handles.cc	View		1 chunk	+6 lines, -2 lines	0 comments	Download
M	src/ic.cc	View	1	1 chunk	+2 lines, -1 line	0 comments	Download
M	src/json-stringifier.h	View	1	2 chunks	+2 lines, -2 lines	0 comments	Download
M	src/objects.cc	View	1	10 chunks	+20 lines, -14 lines	0 comments	Download
M	src/runtime.cc	View	1	5 chunks	+17 lines, -8 lines	0 comments	Download
M	test/cctest/cctest.h	View		1 chunk	+4 lines, -0 lines	0 comments	Download
M	test/cctest/test-compiler.cc	View		11 chunks	+28 lines, -24 lines	0 comments	Download
M	test/cctest/test-parsing.cc	View	1	1 chunk	+2 lines, -2 lines	0 comments	Download
M	test/cctest/test-random.cc	View	1	4 chunks	+10 lines, -9 lines	0 comments	Download

Total messages: 3 (0 generated)

Sven Panne

LGTM. It is somehow tragic that we need that parameter at all, it is basically ...

7 years, 3 months ago (2013-09-05 08:39:20 UTC) #2

dcarney

7 years, 3 months ago (2013-09-05 08:48:55 UTC) #3

Message was sent while issue was closed.

Committed patchset #2 manually as r16545 (presubmit successful).