Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Issue 2366083002: android_webview lint suppressions needed for Android SDK roll. (Closed)

Created:
4 years, 3 months ago by ghost stip (do not use)
Modified:
4 years, 2 months ago
CC:
chromium-reviews, android-webview-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

android_webview lint suppressions needed for Android SDK roll. This is only part of the suppressions needed for a full compile, I'm splitting them up into separate CLs to make OWNERS review easier. BUG=623989 Committed: https://crrev.com/dfa4cb2fde5051bf56444ae4cadb7b903a10bfe2 Cr-Commit-Position: refs/heads/master@{#421030}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M android_webview/javatests/src/org/chromium/android_webview/test/AndroidScrollIntegrationTest.java View 2 chunks +2 lines, -0 lines 0 comments Download
M android_webview/javatests/src/org/chromium/android_webview/test/AwContentsClientShouldOverrideUrlLoadingTest.java View 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 17 (9 generated)
ghost stip (do not use)
jbudorick: ptal sgurun: OWNERS
4 years, 3 months ago (2016-09-23 23:20:21 UTC) #3
sgurun-gerrit only
On 2016/09/23 23:20:21, stip wrote: > jbudorick: ptal > sgurun: OWNERS lgtm
4 years, 3 months ago (2016-09-23 23:45:22 UTC) #4
jbudorick
lgtm
4 years, 3 months ago (2016-09-24 03:45:49 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2366083002/1
4 years, 2 months ago (2016-09-26 03:50:46 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/147789)
4 years, 2 months ago (2016-09-26 06:07:30 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2366083002/1
4 years, 2 months ago (2016-09-26 21:51:51 UTC) #13
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-09-26 23:07:43 UTC) #15
commit-bot: I haz the power
4 years, 2 months ago (2016-09-26 23:09:38 UTC) #17
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/dfa4cb2fde5051bf56444ae4cadb7b903a10bfe2
Cr-Commit-Position: refs/heads/master@{#421030}

Powered by Google App Engine
This is Rietveld 408576698