Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1046)

Issue 2366033002: Revert of Idle cleanup for worker context (Closed)

Created:
4 years, 3 months ago by ericrk
Modified:
4 years, 3 months ago
Reviewers:
danakj, jbauman
CC:
chromium-reviews, jam, sievers+watch_chromium.org, jbauman+watch_chromium.org, darin-cc_chromium.org, piman+watch_chromium.org, kalyank, cc-bugs_chromium.org, danakj+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Idle cleanup for worker context (patchset #5 id:200001 of https://codereview.chromium.org/2353033003/ ) Reason for revert: This appears to be breaking some number of unittests - need to investigate further. Original issue's description: > Idle cleanup for worker context > > Currently, Skia flushes unused items out of its caches after ~1 second > of non-use (50 flushes). This works fine while Skia is in-use, but when > a worker context goes idle we stop calling into Skia altogether. This > means that Skia will never flush out unused cache items from the last > piece of work it did. This can lead to some rather large temporaries > being kept around (~20mb). > > This change adds an idle cleanup process which flushes Skia's caches > and cleans up worker context resources after a worker context is idle > for 1 second. > > BUG=624630 > CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel > > Committed: https://crrev.com/051ae83bf29b52cefd82235ebfb90f203912afbb > Cr-Commit-Position: refs/heads/master@{#420496} TBR=danakj@chromium.org,jbauman@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=624630 Committed: https://crrev.com/a5ce62a749a47a57f8b3b2734eea4cec31e39d9c Cr-Commit-Position: refs/heads/master@{#420741}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+44 lines, -256 lines) Patch
M cc/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M cc/output/context_cache_controller.h View 4 chunks +14 lines, -42 lines 0 comments Download
M cc/output/context_cache_controller.cc View 4 chunks +10 lines, -113 lines 0 comments Download
M cc/output/context_cache_controller_unittest.cc View 3 chunks +6 lines, -65 lines 0 comments Download
M cc/output/context_provider.h View 4 chunks +12 lines, -5 lines 0 comments Download
D cc/output/context_provider.cc View 1 chunk +0 lines, -26 lines 0 comments Download
M content/common/gpu/client/context_provider_command_buffer.cc View 1 chunk +2 lines, -4 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
ericrk
Created Revert of Idle cleanup for worker context
4 years, 3 months ago (2016-09-23 21:36:42 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2366033002/1
4 years, 3 months ago (2016-09-23 21:38:26 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-23 21:51:59 UTC) #4
commit-bot: I haz the power
4 years, 3 months ago (2016-09-23 21:53:55 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a5ce62a749a47a57f8b3b2734eea4cec31e39d9c
Cr-Commit-Position: refs/heads/master@{#420741}

Powered by Google App Engine
This is Rietveld 408576698