Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1506)

Unified Diff: android_webview/glue/java/src/com/android/webview/chromium/WebViewChromium.java

Issue 2366023002: Add WebViewDatabaseAdapter#{get,set}HttpAuthUsernamePassword (Closed)
Patch Set: Add note about when to remove the old functions Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | android_webview/glue/java/src/com/android/webview/chromium/WebViewDatabaseAdapter.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: android_webview/glue/java/src/com/android/webview/chromium/WebViewChromium.java
diff --git a/android_webview/glue/java/src/com/android/webview/chromium/WebViewChromium.java b/android_webview/glue/java/src/com/android/webview/chromium/WebViewChromium.java
index 4a3892673442c2b9ec08979ddb21ba8d4649b45a..e15fd8456b529e291a3080a1d95aa8023b906232 100644
--- a/android_webview/glue/java/src/com/android/webview/chromium/WebViewChromium.java
+++ b/android_webview/glue/java/src/com/android/webview/chromium/WebViewChromium.java
@@ -361,7 +361,7 @@ class WebViewChromium implements WebViewProvider, WebViewProvider.ScrollDelegate
// This is a deprecated API: intentional no-op.
}
- @Override
+ // TODO(ntfschr): remove these functions once API 25 and below is not supported
hush (inactive) 2016/09/26 17:29:20 I believe you can actually just remove this TODO,
public void setHttpAuthUsernamePassword(
final String host, final String realm, final String username, final String password) {
if (checkNeedsPost()) {
@@ -373,10 +373,11 @@ class WebViewChromium implements WebViewProvider, WebViewProvider.ScrollDelegate
});
return;
}
- mAwContents.setHttpAuthUsernamePassword(host, realm, username, password);
+ ((WebViewDatabaseAdapter) mFactory.getWebViewDatabase(mContext))
+ .setHttpAuthUsernamePassword(host, realm, username, password);
}
- @Override
+ // TODO(ntfschr): remove these functions once API 25 and below is not supported
hush (inactive) 2016/09/26 17:29:20 same comment as above.
public String[] getHttpAuthUsernamePassword(final String host, final String realm) {
mFactory.startYourEngines(true);
if (checkNeedsPost()) {
@@ -388,7 +389,8 @@ class WebViewChromium implements WebViewProvider, WebViewProvider.ScrollDelegate
});
return ret;
}
- return mAwContents.getHttpAuthUsernamePassword(host, realm);
+ return ((WebViewDatabaseAdapter) mFactory.getWebViewDatabase(mContext))
+ .getHttpAuthUsernamePassword(host, realm);
}
@Override
« no previous file with comments | « no previous file | android_webview/glue/java/src/com/android/webview/chromium/WebViewDatabaseAdapter.java » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698