Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Issue 2366013002: [sqlite] Bring patches up-to-date with trunk. (Closed)

Created:
4 years, 3 months ago by Scott Hess - ex-Googler
Modified:
4 years, 3 months ago
Reviewers:
michaeln
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[sqlite] Bring patches up-to-date with trunk. CL https://codereview.chromium.org/1753993002 landed changes to allow recover.c to compile outside of SQLite core. It also neglected to fully update the patches, so that patching according to README.chromium resulted in something different from trunk. Bring it back in line with trunk. Additionally update README.chromium with the current version, and tweak the patch instructions to work better. BUG=584407 TBR=michaeln@chromium.org Committed: https://crrev.com/8ae4b9f6d8a95d5256f5d398abe2261c28219373 Cr-Commit-Position: refs/heads/master@{#420744}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+292 lines, -132 lines) Patch
M third_party/sqlite/README.chromium View 2 chunks +2 lines, -1 line 0 comments Download
M third_party/sqlite/patches/0005-Virtual-table-supporting-recovery-of-corrupted-datab.patch View 20 chunks +282 lines, -123 lines 0 comments Download
M third_party/sqlite/patches/0006-Custom-shell.c-helpers-to-load-Chromium-s-ICU-data.patch View 4 chunks +8 lines, -8 lines 0 comments Download

Messages

Total messages: 9 (5 generated)
Scott Hess - ex-Googler
Another TBR, again because it doesn't actually affect the build at all.
4 years, 3 months ago (2016-09-23 21:31:56 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2366013002/1
4 years, 3 months ago (2016-09-23 21:32:59 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-23 22:35:48 UTC) #7
commit-bot: I haz the power
4 years, 3 months ago (2016-09-23 22:39:34 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8ae4b9f6d8a95d5256f5d398abe2261c28219373
Cr-Commit-Position: refs/heads/master@{#420744}

Powered by Google App Engine
This is Rietveld 408576698