Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(844)

Issue 2365983002: [Turbofan] Refactor GapResolver tests in preparation for FP aliasing. (Closed)

Created:
4 years, 3 months ago by bbudge
Modified:
4 years, 2 months ago
Reviewers:
Mircea Trofin, danno
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[Turbofan] Refactor GapResolver tests in preparation for FP aliasing. - Changes tests to canonicalize FP slot/register moves, to simplify testing any implementations that may fragment FP register moves. - Adds code to generate correct ParallelMoves (e.g. no slot sources of different reps overlapping.) - Refactors test functions, so we can add manually generated tests to current fuzzed tests. - Adds SIMD operands, since these can be tested here now. LOG=N BUG=v8:4124 Committed: https://crrev.com/00ac990cc35850f36f67211faf6d8b722d7a7057 Cr-Commit-Position: refs/heads/master@{#39943}

Patch Set 1 #

Patch Set 2 : Eliminate Aliasing test, fragmentation until aliasing is supported. #

Patch Set 3 : Don't reorder operand creation. #

Patch Set 4 : Clean up and relax slot constraints. #

Total comments: 3

Patch Set 5 : Rebase. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+162 lines, -46 lines) Patch
M test/cctest/compiler/test-gap-resolver.cc View 1 2 3 4 12 chunks +162 lines, -46 lines 0 comments Download

Messages

Total messages: 34 (27 generated)
bbudge
4 years, 2 months ago (2016-09-30 00:45:08 UTC) #18
Mircea Trofin
lgtm https://codereview.chromium.org/2365983002/diff/60001/test/cctest/compiler/test-gap-resolver.cc File test/cctest/compiler/test-gap-resolver.cc (right): https://codereview.chromium.org/2365983002/diff/60001/test/cctest/compiler/test-gap-resolver.cc#newcode16 test/cctest/compiler/test-gap-resolver.cc:16: bool IsFPLocation(const InstructionOperand& op) { don't we have ...
4 years, 2 months ago (2016-09-30 04:56:13 UTC) #21
bbudge
https://codereview.chromium.org/2365983002/diff/60001/test/cctest/compiler/test-gap-resolver.cc File test/cctest/compiler/test-gap-resolver.cc (right): https://codereview.chromium.org/2365983002/diff/60001/test/cctest/compiler/test-gap-resolver.cc#newcode16 test/cctest/compiler/test-gap-resolver.cc:16: bool IsFPLocation(const InstructionOperand& op) { On 2016/09/30 04:56:13, Mircea ...
4 years, 2 months ago (2016-09-30 18:16:31 UTC) #22
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2365983002/80001
4 years, 2 months ago (2016-10-03 23:43:40 UTC) #29
bbudge
https://codereview.chromium.org/2365983002/diff/60001/test/cctest/compiler/test-gap-resolver.cc File test/cctest/compiler/test-gap-resolver.cc (right): https://codereview.chromium.org/2365983002/diff/60001/test/cctest/compiler/test-gap-resolver.cc#newcode16 test/cctest/compiler/test-gap-resolver.cc:16: bool IsFPLocation(const InstructionOperand& op) { On 2016/09/30 18:16:31, bbudge ...
4 years, 2 months ago (2016-10-03 23:45:50 UTC) #30
commit-bot: I haz the power
Committed patchset #5 (id:80001)
4 years, 2 months ago (2016-10-03 23:45:55 UTC) #32
commit-bot: I haz the power
4 years, 2 months ago (2016-10-03 23:46:13 UTC) #34
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/00ac990cc35850f36f67211faf6d8b722d7a7057
Cr-Commit-Position: refs/heads/master@{#39943}

Powered by Google App Engine
This is Rietveld 408576698