Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(88)

Side by Side Diff: ui/login/account_picker/user_pod_row.js

Issue 2365943002: cros: Minor issues regarding submit button and tabbing on user pod fixed. (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 /** 5 /**
6 * @fileoverview User pod row implementation. 6 * @fileoverview User pod row implementation.
7 */ 7 */
8 8
9 cr.define('login', function() { 9 cr.define('login', function() {
10 /** 10 /**
(...skipping 700 matching lines...) Expand 10 before | Expand all | Expand 10 after
711 711
712 this.addEventListener('keydown', this.handlePodKeyDown_.bind(this)); 712 this.addEventListener('keydown', this.handlePodKeyDown_.bind(this));
713 this.addEventListener('click', this.handleClickOnPod_.bind(this)); 713 this.addEventListener('click', this.handleClickOnPod_.bind(this));
714 this.addEventListener('mousedown', this.handlePodMouseDown_.bind(this)); 714 this.addEventListener('mousedown', this.handlePodMouseDown_.bind(this));
715 715
716 if (this.pinKeyboard) { 716 if (this.pinKeyboard) {
717 this.pinKeyboard.addEventListener('pin-change', 717 this.pinKeyboard.addEventListener('pin-change',
718 this.handlePinChanged_.bind(this)); 718 this.handlePinChanged_.bind(this));
719 } 719 }
720 720
721 if (this.submitButton)
722 this.submitButton.tabIndex = -1;
xiyuan 2016/09/23 17:42:17 nit: Put this in html ?
sammiequon 2016/09/23 18:00:15 Done.
723
721 this.actionBoxAreaElement.addEventListener('mousedown', 724 this.actionBoxAreaElement.addEventListener('mousedown',
722 stopEventPropagation); 725 stopEventPropagation);
723 this.actionBoxAreaElement.addEventListener('click', 726 this.actionBoxAreaElement.addEventListener('click',
724 this.handleActionAreaButtonClick_.bind(this)); 727 this.handleActionAreaButtonClick_.bind(this));
725 this.actionBoxAreaElement.addEventListener('keydown', 728 this.actionBoxAreaElement.addEventListener('keydown',
726 this.handleActionAreaButtonKeyDown_.bind(this)); 729 this.handleActionAreaButtonKeyDown_.bind(this));
727 730
728 this.actionBoxMenuTitleElement.addEventListener('keydown', 731 this.actionBoxMenuTitleElement.addEventListener('keydown',
729 this.handleMenuTitleElementKeyDown_.bind(this)); 732 this.handleMenuTitleElementKeyDown_.bind(this));
730 this.actionBoxMenuTitleElement.addEventListener('blur', 733 this.actionBoxMenuTitleElement.addEventListener('blur',
(...skipping 704 matching lines...) Expand 10 before | Expand all | Expand 10 after
1435 }, 1438 },
1436 1439
1437 /** 1440 /**
1438 * Resets the input field and updates the tab order of pod controls. 1441 * Resets the input field and updates the tab order of pod controls.
1439 * @param {boolean} takeFocus If true, input field takes focus. 1442 * @param {boolean} takeFocus If true, input field takes focus.
1440 */ 1443 */
1441 reset: function(takeFocus) { 1444 reset: function(takeFocus) {
1442 this.passwordElement.value = ''; 1445 this.passwordElement.value = '';
1443 if (this.pinKeyboard) 1446 if (this.pinKeyboard)
1444 this.pinKeyboard.value = ''; 1447 this.pinKeyboard.value = '';
1448 this.updateInput_();
1445 this.classList.toggle('signing-in', false); 1449 this.classList.toggle('signing-in', false);
1446 if (takeFocus) { 1450 if (takeFocus) {
1447 if (!this.multiProfilesPolicyApplied) 1451 if (!this.multiProfilesPolicyApplied)
1448 this.focusInput(); // This will set a custom tab order. 1452 this.focusInput(); // This will set a custom tab order.
1449 } 1453 }
1450 else 1454 else
1451 this.resetTabOrder(); 1455 this.resetTabOrder();
1452 }, 1456 },
1453 1457
1454 /** 1458 /**
(...skipping 2195 matching lines...) Expand 10 before | Expand all | Expand 10 after
3650 if (pod && pod.multiProfilesPolicyApplied) { 3654 if (pod && pod.multiProfilesPolicyApplied) {
3651 pod.userTypeBubbleElement.classList.remove('bubble-shown'); 3655 pod.userTypeBubbleElement.classList.remove('bubble-shown');
3652 } 3656 }
3653 } 3657 }
3654 }; 3658 };
3655 3659
3656 return { 3660 return {
3657 PodRow: PodRow 3661 PodRow: PodRow
3658 }; 3662 };
3659 }); 3663 });
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698