Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(183)

Issue 2365943002: cros: Minor issues regarding submit button and tabbing on user pod fixed. (Closed)

Created:
4 years, 3 months ago by sammiequon
Modified:
4 years, 3 months ago
Reviewers:
xiyuan, jdufault
CC:
chromium-reviews, alemate+watch_chromium.org, achuith+watch_chromium.org, Greg Levin
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

cros: Minor issues regarding submit button and tabbing on user pod fixed. Previously, when multiple user pods are present, tabbing out of oneresets the password, but the submit button is not disabled. Also the submit button was being tabbed into after the header bar; removed tabbing for submit button since enter key does the same thing. BUG=649370 TEST=none Committed: https://crrev.com/2d5de21399173d1048ddb1fc7320d191b4b63769 Cr-Commit-Position: refs/heads/master@{#420665}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Nit. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M ui/login/account_picker/user_pod_row.js View 1 1 chunk +1 line, -0 lines 0 comments Download
M ui/login/account_picker/user_pod_template.html View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 13 (6 generated)
sammiequon
On 2016/09/23 17:25:51, sammiequon wrote: > mailto:sammiequon@chromium.org changed reviewers: > + mailto:jdufault@chromium.org, mailto:xiyuan@chromium.org jdufault@, xiyuan@ ...
4 years, 3 months ago (2016-09-23 17:26:12 UTC) #3
xiyuan
lgtm https://codereview.chromium.org/2365943002/diff/1/ui/login/account_picker/user_pod_row.js File ui/login/account_picker/user_pod_row.js (right): https://codereview.chromium.org/2365943002/diff/1/ui/login/account_picker/user_pod_row.js#newcode722 ui/login/account_picker/user_pod_row.js:722: this.submitButton.tabIndex = -1; nit: Put this in html ...
4 years, 3 months ago (2016-09-23 17:42:17 UTC) #4
sammiequon
4 years, 3 months ago (2016-09-23 17:59:58 UTC) #5
sammiequon
https://codereview.chromium.org/2365943002/diff/1/ui/login/account_picker/user_pod_row.js File ui/login/account_picker/user_pod_row.js (right): https://codereview.chromium.org/2365943002/diff/1/ui/login/account_picker/user_pod_row.js#newcode722 ui/login/account_picker/user_pod_row.js:722: this.submitButton.tabIndex = -1; On 2016/09/23 17:42:17, xiyuan wrote: > ...
4 years, 3 months ago (2016-09-23 18:00:15 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2365943002/20001
4 years, 3 months ago (2016-09-23 18:01:07 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 3 months ago (2016-09-23 18:16:24 UTC) #11
commit-bot: I haz the power
4 years, 3 months ago (2016-09-23 18:20:04 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/2d5de21399173d1048ddb1fc7320d191b4b63769
Cr-Commit-Position: refs/heads/master@{#420665}

Powered by Google App Engine
This is Rietveld 408576698