Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2365933002: perf.fyi: Add 'mb' to the Win Clang Builder (Closed)

Created:
4 years, 3 months ago by hans
Modified:
4 years, 3 months ago
Reviewers:
dtu, Nico
CC:
chromium-reviews, infra-reviews+build_chromium.org, kjellander-cc_chromium.org
Target Ref:
refs/heads/master
Project:
build
Visibility:
Public.

Description

perf.fyi: Add 'mb' to the Win Clang Builder BUG=649539 TBR=dtu Committed: https://chromium.googlesource.com/chromium/tools/build/+/3215ef3233f90481f50275a9acdb5ba3b2709421

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -1 line) Patch
M scripts/slave/recipe_modules/chromium_tests/chromium_perf_fyi.py View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_perf_fyi_Win_Clang_Builder.json View 2 chunks +23 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (6 generated)
hans
Please take a look.
4 years, 3 months ago (2016-09-23 16:55:39 UTC) #2
Nico
json file change looks sane, so lgtm
4 years, 3 months ago (2016-09-23 16:57:30 UTC) #3
hans
thanks, i'll cq this now and maybe dtu can comment on whether there's some other ...
4 years, 3 months ago (2016-09-23 17:09:50 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2365933002/1
4 years, 3 months ago (2016-09-23 17:10:00 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: Build Presubmit on luci.infra.try (JOB_FAILED, https://luci-milo.appspot.com/swarming/task/3170db2d522cf110)
4 years, 3 months ago (2016-09-23 17:17:10 UTC) #8
Nico
Missing LGTM from an OWNER for these files: scripts/slave/recipe_modules/chromium_tests/chromium_perf_fyi.py I'm only a chromium_fyi per-file owner. ...
4 years, 3 months ago (2016-09-23 17:18:39 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2365933002/1
4 years, 3 months ago (2016-09-23 17:20:21 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/tools/build/+/3215ef3233f90481f50275a9acdb5ba3b2709421
4 years, 3 months ago (2016-09-23 17:24:22 UTC) #14
dtu
4 years, 3 months ago (2016-09-23 21:17:05 UTC) #15
Message was sent while issue was closed. 
lgtm, this is perfect

Powered by Google App Engine
This is Rietveld 408576698