Issue 236593006: Revert of use templates instead of macros to build blitters

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 236593006: Revert of use templates instead of macros to build blitters (Closed)

Created:
6 years, 8 months ago by bungeman-skia

Modified:
6 years, 8 months ago

Reviewers:
mtklein, reed1

CC:
skia-review_googlegroups.com

Base URL:
https://skia.googlecode.com/svn/trunk

Visibility:
Public.

Revert of use templates instead of macros to build blitters (https://codereview.chromium.org/120633004/) Reason for revert: Broke build. Original issue's description: > use templates instead of macros to build blitters > > BUG= > > Committed: http://code.google.com/p/skia/source/detail?r=14178 TBR=mtklein@google.com,reed@google.com NOTREECHECKS=true NOTRY=true BUG= Committed: http://code.google.com/p/skia/source/detail?r=14180

Created: 6 years, 8 months ago

(Patch set is too large to download)

	Unified diffs	Side-by-side diffs	Stats (+168 lines, -211 lines)			Patch
M	src/core/SkBitmapProcState_matrix.h	View	5 chunks	+138 lines, -0 lines	0 comments	Download
M	src/core/SkBitmapProcState_matrixProcs.cpp	View	12 chunks	+30 lines, -87 lines	0 comments	Download
D	src/core/SkBitmapProcState_matrix_template.h	View	1 chunk	+0 lines, -124 lines	0 comments	Download

Total messages: 3 (0 generated)

bungeman-skia

Created Revert of use templates instead of macros to build blitters

6 years, 8 months ago (2014-04-14 15:45:37 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/bungeman@google.com/236593006/1

6 years, 8 months ago (2014-04-14 15:45:47 UTC) #2

Message was sent while issue was closed.

Change committed as 14180