Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(106)

Issue 236593003: Align srcset parsing with spec changes (Closed)

Created:
6 years, 8 months ago by Yoav Weiss
Modified:
6 years, 8 months ago
Reviewers:
eseidel
CC:
blink-reviews, dglazkov+blink, adamk+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Align srcset parsing with spec changed This CL align the srcset parsing algorithm with recent picture spec changes. Specifically: * Src URL are now not part of the source selection algoritm, as per https://github.com/ResponsiveImagesCG/picture-element/pull/147 * 0w resources are ignored, to avoid 0/0 operations, and because they make no sense, as per https://github.com/ResponsiveImagesCG/picture-element/pull/151 BUG=357586 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=171489

Patch Set 1 #

Total comments: 2

Patch Set 2 : Review comments #

Patch Set 3 : Added some more tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -8 lines) Patch
M Source/core/html/parser/HTMLSrcsetParser.h View 1 3 chunks +13 lines, -1 line 0 comments Download
M Source/core/html/parser/HTMLSrcsetParser.cpp View 6 chunks +14 lines, -7 lines 0 comments Download
M Source/core/html/parser/HTMLSrcsetParserTest.cpp View 1 2 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Yoav Weiss
6 years, 8 months ago (2014-04-13 19:39:16 UTC) #1
eseidel
https://codereview.chromium.org/236593003/diff/1/Source/core/html/parser/HTMLSrcsetParser.h File Source/core/html/parser/HTMLSrcsetParser.h (right): https://codereview.chromium.org/236593003/diff/1/Source/core/html/parser/HTMLSrcsetParser.h#newcode56 Source/core/html/parser/HTMLSrcsetParser.h:56: enum Origin { Is this OriginSource? This is controlling ...
6 years, 8 months ago (2014-04-13 20:57:55 UTC) #2
Yoav Weiss
On 2014/04/13 20:57:55, eseidel wrote: > https://codereview.chromium.org/236593003/diff/1/Source/core/html/parser/HTMLSrcsetParser.h > File Source/core/html/parser/HTMLSrcsetParser.h (right): > > https://codereview.chromium.org/236593003/diff/1/Source/core/html/parser/HTMLSrcsetParser.h#newcode56 > ...
6 years, 8 months ago (2014-04-14 07:28:19 UTC) #3
Yoav Weiss
On 2014/04/14 07:28:19, Yoav Weiss wrote: > On 2014/04/13 20:57:55, eseidel wrote: > > > ...
6 years, 8 months ago (2014-04-14 09:37:56 UTC) #4
eseidel
lgtm
6 years, 8 months ago (2014-04-14 17:08:15 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yoav@yoav.ws/236593003/40001
6 years, 8 months ago (2014-04-14 17:08:28 UTC) #6
commit-bot: I haz the power
6 years, 8 months ago (2014-04-14 17:19:14 UTC) #7
Message was sent while issue was closed.
Change committed as 171489

Powered by Google App Engine
This is Rietveld 408576698