Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(128)

Issue 2365883002: Expose the MediaStream interface (Closed)

Created:
4 years, 3 months ago by foolip
Modified:
4 years, 2 months ago
CC:
chromium-reviews, blink-reviews, haraken, tommyw+watchlist_chromium.org, mcasas+watch+mediastream_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Expose the MediaStream interface Intent to Ship: https://groups.google.com/a/chromium.org/d/msg/blink-dev/9WIVyDz1T34/5Nmj46UXAwAJ BUG=649331 Committed: https://crrev.com/febb0c97b0e7a59fbd1e3ca9bbf00759e684d4b0 Cr-Commit-Position: refs/heads/master@{#421502}

Patch Set 1 #

Patch Set 2 : update tests #

Patch Set 3 : update fast/js/constructor-length.html #

Patch Set 4 : drop TODO #

Unified diffs Side-by-side diffs Delta from patch set Stats (+120 lines, -70 lines) Patch
M content/test/data/media/getusermedia.html View 1 4 chunks +4 lines, -4 lines 0 comments Download
M content/test/data/media/peerconnection-call.html View 1 3 chunks +3 lines, -3 lines 0 comments Download
M ppapi/examples/video_effects/video_effects.html View 1 8 chunks +9 lines, -11 lines 0 comments Download
M ppapi/tests/test_video_destination.cc View 1 2 chunks +1 line, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/events/constructors/media-stream-event-constructor.html View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/fast/js/constructor-length-expected.txt View 1 2 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/fast/mediastream/MediaStream-onactive-oninactive.html View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/fast/mediastream/MediaStreamConstructor.html View 1 5 chunks +33 lines, -23 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/mediastream/MediaStreamConstructor-expected.txt View 1 11 chunks +26 lines, -21 lines 0 comments Download
M third_party/WebKit/LayoutTests/virtual/stable/webexposed/global-interface-listing-expected.txt View 1 chunk +20 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt View 1 2 3 1 chunk +20 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/mediastream/MediaStream.idl View 1 2 3 1 chunk +1 line, -3 lines 0 comments Download

Messages

Total messages: 29 (18 generated)
foolip
PTAL bbudge@/raymes@: ppapi/ guidou@/tommi@: everything else
4 years, 2 months ago (2016-09-27 08:51:04 UTC) #15
Guido Urdaneta
lgtm
4 years, 2 months ago (2016-09-27 08:54:26 UTC) #16
tommi (sloooow) - chröme
lgtm
4 years, 2 months ago (2016-09-27 08:58:41 UTC) #17
Srirama
Do we need to update here also? https://cs.chromium.org/chromium/src/android_webview/tools/system_webview_shell/test/data/webexposed/global-interface-listing-expected.txt?q=webkitmediastream&sq=package:chromium&dr=C&l=5570
4 years, 2 months ago (2016-09-27 09:32:18 UTC) #19
foolip
On 2016/09/27 09:32:18, Srirama_OnBizTrip_till_26OCT wrote: > Do we need to update here also? > https://cs.chromium.org/chromium/src/android_webview/tools/system_webview_shell/test/data/webexposed/global-interface-listing-expected.txt?q=webkitmediastream&sq=package:chromium&dr=C&l=5570 ...
4 years, 2 months ago (2016-09-27 09:46:40 UTC) #20
Srirama
On 2016/09/27 09:46:40, foolip wrote: > On 2016/09/27 09:32:18, Srirama_OnBizTrip_till_26OCT wrote: > > Do we ...
4 years, 2 months ago (2016-09-27 10:03:15 UTC) #21
foolip
On 2016/09/27 10:03:15, Srirama_OnBizTrip_till_26OCT wrote: > On 2016/09/27 09:46:40, foolip wrote: > > On 2016/09/27 ...
4 years, 2 months ago (2016-09-27 10:29:48 UTC) #22
bbudge
ppapi lgtm
4 years, 2 months ago (2016-09-27 17:37:14 UTC) #23
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2365883002/60001
4 years, 2 months ago (2016-09-28 08:44:56 UTC) #25
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 2 months ago (2016-09-28 12:31:37 UTC) #27
commit-bot: I haz the power
4 years, 2 months ago (2016-09-28 12:33:59 UTC) #29
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/febb0c97b0e7a59fbd1e3ca9bbf00759e684d4b0
Cr-Commit-Position: refs/heads/master@{#421502}

Powered by Google App Engine
This is Rietveld 408576698