Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(278)

Issue 2365813002: fix warning on visual C for mips cpu detect (Closed)

Created:
4 years, 2 months ago by fbarchard1
Modified:
4 years, 2 months ago
Target Ref:
refs/heads/master
Project:
libyuv
Visibility:
Public.

Description

fix warning on visual C for mips cpu detect follow up warning fixs cpu_id.cc(167): warning C4267: 'initializing': conversion from 'size_t' to 'int', possible loss of data lint warning: cpu_id.cc:171: Missing space before ( in if( [whitespace/parens] [5] TBR=manojkumar.bhosale@imgtec.com BUG=libyuv:634 TEST=try bots for windows. Committed: https://chromium.googlesource.com/libyuv/libyuv/+/34a29bf756234839c7829b0e76d6e603aaa4e5d4

Patch Set 1 #

Patch Set 2 : fix warning on visual C for mips cpu detect #

Patch Set 3 : fix warning on visual C for mips cpu detect #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -5 lines) Patch
M libyuv.gyp View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M libyuv_test.gyp View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M source/cpu_id.cc View 1 2 chunks +5 lines, -5 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
fbarchard1
follow up fix for mips
4 years, 2 months ago (2016-09-23 00:59:20 UTC) #3
fbarchard1
this fixes the initial build break but needs followup for the gyp and gn builds. ...
4 years, 2 months ago (2016-09-23 01:25:44 UTC) #4
fbarchard1
4 years, 2 months ago (2016-09-23 01:25:56 UTC) #6
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as
34a29bf756234839c7829b0e76d6e603aaa4e5d4 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698