Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(563)

Unified Diff: tests/standalone/io/file_error_test.dart

Issue 23658048: Revert "dart:io | Change File.fullPath to FileSystemEntity.resolveSymbolicLinks." (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « sdk/lib/io/link.dart ('k') | tests/standalone/io/file_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tests/standalone/io/file_error_test.dart
diff --git a/tests/standalone/io/file_error_test.dart b/tests/standalone/io/file_error_test.dart
index 8b1049a4a169d7853277a918f7eb983e2ec35960..d8dc8aadf0947dd19adc9db0d1dcd07778a15359 100644
--- a/tests/standalone/io/file_error_test.dart
+++ b/tests/standalone/io/file_error_test.dart
@@ -130,29 +130,29 @@ void testCreateInNonExistentDirectory() {
});
}
-bool checkResolveSymbolicLinksOnNonExistentDirectoryException(e) {
+bool checkFullPathOnNonExistentDirectoryException(e) {
Expect.isTrue(e is FileException);
Expect.isTrue(e.osError != null);
- Expect.isTrue(e.toString().indexOf("Cannot resolve symbolic links") != -1);
+ Expect.isTrue(e.toString().indexOf("Cannot retrieve full path") != -1);
// File not not found has error code 2 on all supported platforms.
Expect.equals(2, e.osError.errorCode);
return true;
}
-void testResolveSymbolicLinksOnNonExistentDirectory() {
+void testFullPathOnNonExistentDirectory() {
asyncStart();
Directory temp = tempDir();
var file = new File("${temp.path}/nonExistentDirectory");
// Full path non-existent directory should throw exception.
- Expect.throws(() => file.resolveSymbolicLinksSync(),
- (e) => checkResolveSymbolicLinksOnNonExistentDirectoryException(e));
+ Expect.throws(() => file.fullPathSync(),
+ (e) => checkFullPathOnNonExistentDirectoryException(e));
- var resolvedFuture = file.resolveSymbolicLinks();
- resolvedFuture.then((path) => Expect.fail("Unreachable code $path"))
+ var fullPathFuture = file.fullPath();
+ fullPathFuture.then((path) => Expect.fail("Unreachable code $path"))
.catchError((error) {
- checkResolveSymbolicLinksOnNonExistentDirectoryException(error);
+ checkFullPathOnNonExistentDirectoryException(error);
temp.deleteSync(recursive: true);
asyncEnd();
});
@@ -424,7 +424,7 @@ main() {
testDeleteNonExistent();
testLengthNonExistent();
testCreateInNonExistentDirectory();
- testResolveSymbolicLinksOnNonExistentDirectory();
+ testFullPathOnNonExistentDirectory();
testReadAsBytesNonExistent();
testReadAsTextNonExistent();
testReadAsLinesNonExistent();
« no previous file with comments | « sdk/lib/io/link.dart ('k') | tests/standalone/io/file_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698