Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(549)

Issue 23658042: Merge 157259 "Fix threading races on WebAudioSourceProviderImpl:..." (Closed)

Created:
7 years, 3 months ago by haraken
Modified:
7 years, 3 months ago
Reviewers:
haraken
CC:
blink-reviews, nessy, eae+blinkwatch, feature-media-reviews_chromium.org, dglazkov+blink, adamk+blink_chromium.org, vcarbune.chromium
Visibility:
Public.

Description

Merge 157259 "Fix threading races on WebAudioSourceProviderImpl:..." > Fix threading races on WebAudioSourceProviderImpl::provideInput > > Fix threading races on WebAudioSourceProviderImpl::provideInput > > According to the crash report (https://cluster-fuzz.appspot.com/testcase?key=4697390229487616), > there is a threading race. Specifically, WebAudioSourceProviderImpl can be destructed by the main thread while WebAudioSourceProviderImpl::Stop() is being called by the audio thread. > > The core problem is that we're not calling WebAudioSourceProviderImpl::setClient(NULL) when HTMLMediaElement clears the audio source provider. > > BUG=284786 > No tests because the crash depends on threading races and thus not reproducible. > > Review URL: https://chromiumcodereview.appspot.com/23969007 TBR=haraken@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=157694

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -0 lines) Patch
Source/core/html/HTMLMediaElement.cpp View 2 chunks +8 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
haraken
7 years, 3 months ago (2013-09-12 19:25:36 UTC) #1
haraken
7 years, 3 months ago (2013-09-12 19:25:48 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 manually as r157694.

Powered by Google App Engine
This is Rietveld 408576698