Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7544)

Unified Diff: chrome/common/extensions/api/file_browser_private.json

Issue 23658009: Replace mountType by volumeType on fileBrowserPrivate APIs. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/common/extensions/api/file_browser_private.json
diff --git a/chrome/common/extensions/api/file_browser_private.json b/chrome/common/extensions/api/file_browser_private.json
index 939c12986dea6e33da1654c0e744758e52f1051e..fbcb6223075e1ac19e8dbd23a9e0ad286c876207 100644
--- a/chrome/common/extensions/api/file_browser_private.json
+++ b/chrome/common/extensions/api/file_browser_private.json
@@ -138,11 +138,11 @@
"optional": true,
"description": "The path to the mounted device, archive file or network resource."
},
- "mountType": {
+ "volumeType": {
"type": "string",
"optional": true,
- "enum": ["device", "file", "network"],
- "description": "Type of the mount."
+ "enum": ["drive", "downloads", "removable", "archive"],
+ "description": "Type of the mounted volume."
},
"mountCondition": {
"type": "string",
@@ -282,10 +282,10 @@
"optional": true,
"description": "Path that sourcePath was mounted to."
},
- "mountType": {
+ "volumeType": {
"type": "string",
- "enum": ["device", "file", "network", "drive"],
- "description": "Type of the mount."
+ "enum": ["drive", "downloads", "removable", "archive"],
benwells 2013/09/06 01:26:28 Is it possible to extract this into a shared volum
satorux1 2013/09/06 01:57:37 I think he plans to unify MountCompletedEvent, Vol
hidehiko 2013/09/06 03:50:39 Thank you for your comment. Sharing sounds good to
satorux1 2013/09/06 04:17:59 Sounds good.
+ "description": "Type of the mounted volume."
}
}
},
@@ -741,11 +741,13 @@
"type": "string",
"description": "Mount point source. For compressed files it is relative file path within external file system"
},
+ // TODO(hidehiko): After the refactoring, we won't need to request
+ // mounting the Drive. Then remove this param.
{
- "name": "mountType",
+ "name": "volumeType",
"type": "string",
- "enum": ["device", "file", "network", "drive"],
- "description": "Mount point type. 'file' for compressed files"
+ "enum": ["drive", "archive"],
+ "description": "Type of the mounted volume"
},
{
"name": "options",

Powered by Google App Engine
This is Rietveld 408576698