Replace mountType by volumeType on fileBrowserPrivate APIs.

chrome/browser/chromeos/extensions/file_manager/private_api_util.h

Index: chrome/browser/chromeos/extensions/file_manager/private_api_util.h
diff --git a/chrome/browser/chromeos/extensions/file_manager/private_api_util.h b/chrome/browser/chromeos/extensions/file_manager/private_api_util.h
index be2e15e0482b4b86a2d6cd6e2bc483775667beed..a6ff782a2917c0d129c0539ffbf22537aa92f24a 100644
--- a/chrome/browser/chromeos/extensions/file_manager/private_api_util.h
+++ b/chrome/browser/chromeos/extensions/file_manager/private_api_util.h
@@ -8,6 +8,7 @@
 #define CHROME_BROWSER_CHROMEOS_EXTENSIONS_FILE_MANAGER_PRIVATE_API_UTIL_H_
 
 #include "base/callback_forward.h"
+#include "chrome/browser/chromeos/extensions/file_manager/volume_manager.h"
 #include "chrome/browser/google_apis/gdata_wapi_parser.h"
 #include "url/gurl.h"
 
@@ -25,6 +26,9 @@ struct SelectedFileInfo;
 namespace file_manager {
 namespace util {
 
+// Returns string representaion of VolumeType.
+std::string VolumeTypeToString(VolumeType type);

[satorux1, 2013/09/04 05:01:55]

Move this to volume_manager.h where VolumeType is defined? We don't want to 
dump even more random things in private_api_util.h. :P

[hidehiko, 2013/09/04 05:13:25]

This is rather mapping from VolumeType to "string represention of enum in
private API" than just a stringify the enum, so IMHO this is a part of private
API rather than VolumeManager, which will be split from private API eventually.
So, I'd like to keep this here.
Note that the name may be a bit confusing, but I followed the current API
implementation manner...

[satorux1, 2013/09/05 01:46:24]

Oh I see. Then let's clarify by the function comment:

// Converts VolumeType to a string enum (XxxType) used in the private API.

Maybe also rename the function:

VolumeTypeToStringEnum()

[hidehiko, 2013/09/05 03:12:41]

VolumeTypeToStringEnum sounds better. Done.

+
 // Returns the ID of the tab associated with the dispatcher. Returns 0 on
 // error.
 int32 GetTabId(ExtensionFunctionDispatcher* dispatcher);