chrome/browser/sync/test/integration/two_client_passwords_sync_test.cc - Issue 2365763002: [Sync] Removed passphrase helper methods, removed ((n)) pattern, and fixed lint violations.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/sync/test/integration/two_client_passwords_sync_test.cc

Issue 2365763002: [Sync] Removed passphrase helper methods, removed ((n)) pattern, and fixed lint violations. (Closed)

Patch Set: Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/sync/test/integration/sync_test.cc ('K') | « chrome/browser/sync/test/integration/two_client_bookmarks_sync_test.cc ('k') | chrome/browser/sync/test/integration/two_client_search_engines_sync_test.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/sync/test/integration/two_client_passwords_sync_test.cc

diff --git a/chrome/browser/sync/test/integration/two_client_passwords_sync_test.cc b/chrome/browser/sync/test/integration/two_client_passwords_sync_test.cc

index aebe553e77e77d422ccb70e1f48e46c2bcdf8b1b..b78c629d3dbf29cf11dc5cc0d18c1f8df5bc5752 100644

--- a/chrome/browser/sync/test/integration/two_client_passwords_sync_test.cc

+++ b/chrome/browser/sync/test/integration/two_client_passwords_sync_test.cc

@@ -31,8 +31,6 @@ using passwords_helper::GetVerifierPasswordCount;

using passwords_helper::GetVerifierPasswordStore;

using passwords_helper::RemoveLogin;

using passwords_helper::RemoveLogins;

-using passwords_helper::SetDecryptionPassphrase;

-using passwords_helper::SetEncryptionPassphrase;

using passwords_helper::UpdateLogin;

using sync_integration_test_util::AwaitPassphraseAccepted;

using sync_integration_test_util::AwaitPassphraseRequired;

@@ -85,11 +83,11 @@ IN_PROC_BROWSER_TEST_F(TwoClientPasswordsSyncTest,

SetEncryptionPassphrase(0, kValidPassphrase,

browser_sync::ProfileSyncService::EXPLICIT);

- ASSERT_TRUE(AwaitPassphraseAccepted(GetSyncService((0))));

+ ASSERT_TRUE(AwaitPassphraseAccepted(GetSyncService(0)));

- ASSERT_TRUE(AwaitPassphraseRequired(GetSyncService((1))));

+ ASSERT_TRUE(AwaitPassphraseRequired(GetSyncService(1)));

ASSERT_TRUE(SetDecryptionPassphrase(1, kValidPassphrase));

- ASSERT_TRUE(AwaitPassphraseAccepted(GetSyncService((1))));

+ ASSERT_TRUE(AwaitPassphraseAccepted(GetSyncService(1)));

PasswordForm form = CreateTestPasswordForm(0);

AddLogin(GetPasswordStore(0), form);