chrome/browser/sync/test/integration/sync_exponential_backoff_test.cc - Issue 2365763002: [Sync] Removed passphrase helper methods, removed ((n)) pattern, and fixed lint violations.

Unified Diff: chrome/browser/sync/test/integration/sync_exponential_backoff_test.cc

Issue 2365763002: [Sync] Removed passphrase helper methods, removed ((n)) pattern, and fixed lint violations. (Closed)

Patch Set: Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/sync/test/integration/single_client_app_list_sync_test.cc ('K') | « chrome/browser/sync/test/integration/sync_auth_test.cc ('k') | chrome/browser/sync/test/integration/sync_extension_helper.cc » ('j') | chrome/browser/sync/test/integration/sync_test.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/sync/test/integration/sync_exponential_backoff_test.cc

diff --git a/chrome/browser/sync/test/integration/sync_exponential_backoff_test.cc b/chrome/browser/sync/test/integration/sync_exponential_backoff_test.cc

index 05a1da6e39defd00232ff9eae16f4d60a2500664..962129704be5d638e3a4b96ab4ad44654300b8c4 100644

--- a/chrome/browser/sync/test/integration/sync_exponential_backoff_test.cc

+++ b/chrome/browser/sync/test/integration/sync_exponential_backoff_test.cc

@@ -68,7 +68,7 @@ IN_PROC_BROWSER_TEST_F(SyncExponentialBackoffTest, OfflineToOnline) {

// Add an item and ensure that sync is successful.

ASSERT_TRUE(AddFolder(0, 0, "folder1"));

- ASSERT_TRUE(AwaitCommitActivityCompletion(GetSyncService((0))));

+ ASSERT_TRUE(AwaitCommitActivityCompletion(GetSyncService(0)));

GetFakeServer()->DisableNetwork();

@@ -77,8 +77,7 @@ IN_PROC_BROWSER_TEST_F(SyncExponentialBackoffTest, OfflineToOnline) {

// Verify that the client goes into exponential backoff while it is unable to

// reach the sync server.

- ExponentialBackoffChecker exponential_backoff_checker(

- GetSyncService((0)));

+ ExponentialBackoffChecker exponential_backoff_checker(GetSyncService(0));

exponential_backoff_checker.Wait();

ASSERT_FALSE(exponential_backoff_checker.TimedOut());

@@ -91,7 +90,7 @@ IN_PROC_BROWSER_TEST_F(SyncExponentialBackoffTest, OfflineToOnline) {

base::Time network_notification_time = base::Time::Now();

// Verify that sync was able to recover.

- ASSERT_TRUE(AwaitCommitActivityCompletion(GetSyncService((0))));

+ ASSERT_TRUE(AwaitCommitActivityCompletion(GetSyncService(0)));

ASSERT_TRUE(ModelMatchesVerifier(0));

// Verify that recovery time is short. Without canary job recovery time would

@@ -107,7 +106,7 @@ IN_PROC_BROWSER_TEST_F(SyncExponentialBackoffTest, TransientErrorTest) {

// Add an item and ensure that sync is successful.

ASSERT_TRUE(AddFolder(0, 0, "folder1"));

- ASSERT_TRUE(AwaitCommitActivityCompletion(GetSyncService((0))));

+ ASSERT_TRUE(AwaitCommitActivityCompletion(GetSyncService(0)));

GetFakeServer()->TriggerError(sync_pb::SyncEnums::TRANSIENT_ERROR);

@@ -116,8 +115,7 @@ IN_PROC_BROWSER_TEST_F(SyncExponentialBackoffTest, TransientErrorTest) {

// Verify that the client goes into exponential backoff while it is unable to

// reach the sync server.

- ExponentialBackoffChecker exponential_backoff_checker(

- GetSyncService((0)));

+ ExponentialBackoffChecker exponential_backoff_checker(GetSyncService(0));

exponential_backoff_checker.Wait();

ASSERT_FALSE(exponential_backoff_checker.TimedOut());

}