[Sync] Removed passphrase helper methods, removed ((n)) pattern, and fixed lint violations.

chrome/browser/sync/test/integration/sync_extension_helper.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/sync/test/integration/sync_extension_helper.h"
 
+#include <list>
+#include <memory>
+#include <utility>
+
 #include "base/files/file_path.h"
 #include "base/files/file_util.h"
 #include "base/guid.h"
 #include "base/logging.h"
 #include "base/strings/string_number_conversions.h"
 #include "base/strings/string_util.h"
 #include "base/values.h"
 #include "chrome/browser/extensions/extension_service.h"
 #include "chrome/browser/extensions/extension_util.h"
 #include "chrome/browser/extensions/pending_extension_info.h"
@@ skipping 162 matching lines @@
       extensions::ExtensionSystem::Get(profile)
           ->extension_service()
           ->pending_extension_manager();
 
   std::list<std::string> pending_crx_ids;
   pending_extension_manager->GetPendingIdsForUpdateCheck(&pending_crx_ids);
 
   std::list<std::string>::const_iterator iter;
   const extensions::PendingExtensionInfo* info = NULL;
   for (iter = pending_crx_ids.begin(); iter != pending_crx_ids.end(); ++iter) {
-    ASSERT_TRUE((info = pending_extension_manager->GetById(*iter)));
+    ASSERT_TRUE(info = pending_extension_manager->GetById(*iter));
     if (!info->is_from_sync())
       continue;
 
     StringMap::const_iterator iter2 = id_to_name_.find(*iter);
     if (iter2 == id_to_name_.end()) {
       ADD_FAILURE() << "Could not get name for id " << *iter
                     << " (profile = " << profile->GetDebugName() << ")";
       continue;
     }
     TypeMap::const_iterator iter3 = id_to_type_.find(*iter);
@@ skipping 225 matching lines @@
     EXPECT_EQ(expected_id, extension->id());
     return NULL;
   }
   DVLOG(2) << "created extension with name = "
            << name << ", id = " << expected_id;
   (it->second)[name] = extension;
   id_to_name_[expected_id] = name;
   id_to_type_[expected_id] = type;
   return extension;
 }