Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(73)

Issue 2365753003: mus ws: Move 'reset(new' to base::MakeUnique. (Closed)

Created:
4 years, 2 months ago by Elliot Glaysher
Modified:
4 years, 2 months ago
Reviewers:
sky
CC:
chromium-reviews, rjkroege, dcheng
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

mus ws: Move 'reset(new' to base::MakeUnique. BUG=none Committed: https://crrev.com/37c2618ddb2866b8487ba96c5ff4d77342c8ef56 Cr-Commit-Position: refs/heads/master@{#420934}

Patch Set 1 #

Patch Set 2 : Merge with tot #

Unified diffs Side-by-side diffs Delta from patch set Stats (+56 lines, -51 lines) Patch
M services/ui/ws/display.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M services/ui/ws/drag_controller_unittest.cc View 2 chunks +5 lines, -5 lines 0 comments Download
M services/ui/ws/event_dispatcher_unittest.cc View 1 chunk +7 lines, -5 lines 0 comments Download
M services/ui/ws/focus_controller.cc View 2 chunks +6 lines, -4 lines 0 comments Download
M services/ui/ws/frame_generator.cc View 1 1 chunk +3 lines, -3 lines 0 comments Download
M services/ui/ws/frame_generator_unittest.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M services/ui/ws/gpu_service_proxy.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M services/ui/ws/platform_display.cc View 1 1 chunk +3 lines, -3 lines 0 comments Download
M services/ui/ws/scheduled_animation_group.cc View 1 chunk +1 line, -1 line 0 comments Download
M services/ui/ws/server_window.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M services/ui/ws/test_utils.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M services/ui/ws/user_activity_monitor_unittest.cc View 1 chunk +2 lines, -1 line 0 comments Download
M services/ui/ws/window_manager_client_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M services/ui/ws/window_server.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M services/ui/ws/window_tree.cc View 1 chunk +1 line, -1 line 0 comments Download
M services/ui/ws/window_tree_client_unittest.cc View 7 chunks +10 lines, -10 lines 0 comments Download

Messages

Total messages: 17 (10 generated)
Elliot Glaysher
It is worse to have a '.reset(new X)' next to a 'base::MakeUnique<X>()' because it is ...
4 years, 2 months ago (2016-09-23 23:42:18 UTC) #6
sky
LGTM
4 years, 2 months ago (2016-09-26 15:12:59 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2365753003/1
4 years, 2 months ago (2016-09-26 17:06:53 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/148149) linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, ...
4 years, 2 months ago (2016-09-26 17:10:30 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2365753003/20001
4 years, 2 months ago (2016-09-26 17:19:03 UTC) #14
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 2 months ago (2016-09-26 18:15:09 UTC) #15
commit-bot: I haz the power
4 years, 2 months ago (2016-09-26 18:18:10 UTC) #17
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/37c2618ddb2866b8487ba96c5ff4d77342c8ef56
Cr-Commit-Position: refs/heads/master@{#420934}

Powered by Google App Engine
This is Rietveld 408576698