Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(567)

Issue 2365753002: Make sure all repo hostnames are listed via vars in DEPS. (Closed)

Created:
4 years, 2 months ago by Dirk Pranke
Modified:
4 years, 2 months ago
Reviewers:
Michael Moss
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make sure all repo hostnames are listed via vars in DEPS. This allows users to override the hostnames to use local mirrors. Also, fix the indentation of the file to be consistent. R=mmoss@chromium.org Committed: https://crrev.com/4778c7154107491f0288a74c51f2f2fe40e0c9a2 Cr-Commit-Position: refs/heads/master@{#420530}

Patch Set 1 #

Patch Set 2 : merge #

Unified diffs Side-by-side diffs Delta from patch set Stats (+79 lines, -76 lines) Patch
M DEPS View 1 8 chunks +79 lines, -76 lines 0 comments Download

Messages

Total messages: 14 (7 generated)
Dirk Pranke
4 years, 2 months ago (2016-09-22 23:04:45 UTC) #1
Michael Moss
lgtm
4 years, 2 months ago (2016-09-22 23:17:09 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2365753002/1
4 years, 2 months ago (2016-09-22 23:53:46 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: ios-device on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds/73821) ios-simulator on master.tryserver.chromium.mac (JOB_FAILED, ...
4 years, 2 months ago (2016-09-22 23:57:41 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2365753002/20001
4 years, 2 months ago (2016-09-23 00:09:36 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 2 months ago (2016-09-23 01:16:18 UTC) #12
commit-bot: I haz the power
4 years, 2 months ago (2016-09-23 01:19:31 UTC) #14
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/4778c7154107491f0288a74c51f2f2fe40e0c9a2
Cr-Commit-Position: refs/heads/master@{#420530}

Powered by Google App Engine
This is Rietveld 408576698