chrome/browser/resources/media_router/elements/media_router_container/media_router_container.js - Issue 2365743002: [MR UI] Add a wrapper div to the sink list and search results in the MR dialog

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/media_router/elements/media_router_container/media_router_container.js

Issue 2365743002: [MR UI] Add a wrapper div to the sink list and search results in the MR dialog (Closed)

Patch Set: Rebase, fix browser test Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/resources/media_router/elements/media_router_container/media_router_container.html ('k') | chrome/test/data/webui/media_router/media_router_container_filter_tests.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/media_router/elements/media_router_container/media_router_container.js

diff --git a/chrome/browser/resources/media_router/elements/media_router_container/media_router_container.js b/chrome/browser/resources/media_router/elements/media_router_container/media_router_container.js

index 0d93b89bd27663976cc6d65250b0efec5259fee0..9e149ca7aadec32a7cad87d47b20e35c48e610cd 100644

--- a/chrome/browser/resources/media_router/elements/media_router_container/media_router_container.js

+++ b/chrome/browser/resources/media_router/elements/media_router_container/media_router_container.js

@@ -1286,7 +1286,7 @@ Polymer({

var focusedSink =

this.$$('#searchResults').itemForElement(focusedElem).sinkItem;

setTimeout(function() {

- var sinkListPaperMenu = this.$$('#sink-list');

+ var sinkListPaperMenu = this.$$('#sink-list-paper-menu');

var sinks = sinkListPaperMenu.children;

var sinkList = this.$$('#sinkList');

for (var i = 0; i < sinks.length; i++) {

@@ -1377,7 +1377,6 @@ Polymer({

var searchFinalTop = hasList ? list.offsetHeight - search.offsetHeight :

deviceMissing.offsetHeight;

resultsContainer.style['position'] = 'absolute';

- resultsContainer.style['overflow-y'] = '';

var duration =

this.computeAnimationDuration_(searchFinalTop - searchInitialTop);

@@ -1860,7 +1859,6 @@ Polymer({

resultsContainer.style['position'] = 'relative';

resultsContainer.style['padding-top'] = resultsPaddingTop;

resultsContainer.style['top'] = '';

- resultsContainer.style['overflow-y'] = 'auto';

view.style['overflow'] = '';

view.style['padding-bottom'] = '';

@@ -2340,7 +2338,7 @@ Polymer({

if (hasSearch && sinkList) {

// This would need to be reset to '' if search could be disabled again,

// but once it's enabled it can't be disabled again.

- sinkList.style.paddingBottom = '0';

+ this.$$('#sink-list-paper-menu').style.paddingBottom = '0';

}

var sinkListPadding =

sinkList ? this.computeElementVerticalPadding_(sinkList) : 0;