Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(141)

Issue 2365703002: It is possible to try and draw to an unsupported format. Let this go. (Closed)

Created:
4 years, 3 months ago by Brian Osman
Modified:
4 years, 3 months ago
Reviewers:
mtklein, bsalomon
CC:
reviews_skia.org
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

It is possible to try and draw to an unsupported format. Let this go. Squelches assert firing in gradient code on low-end Android bots. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2365703002 Committed: https://skia.googlesource.com/skia/+/c68e8924c57487f39d5647f6e68bde522940b728

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M src/effects/gradients/SkGradientShader.cpp View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
Brian Osman
4 years, 3 months ago (2016-09-22 20:51:25 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2365703002/1
4 years, 3 months ago (2016-09-22 20:51:43 UTC) #5
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
4 years, 3 months ago (2016-09-22 20:51:44 UTC) #6
mtklein
lgtm
4 years, 3 months ago (2016-09-22 20:51:54 UTC) #7
commit-bot: I haz the power
4 years, 3 months ago (2016-09-22 21:27:37 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/c68e8924c57487f39d5647f6e68bde522940b728

Powered by Google App Engine
This is Rietveld 408576698