Issue 2365693002: Add logging to fetch, retry if gitiles gives us weird unicode

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2365693002: Add logging to fetch, retry if gitiles gives us weird unicode (Closed)

Created:
4 years, 3 months ago by martiniss

Modified:
4 years, 3 months ago

Reviewers:
dnj, iannucci

CC:
chromium-reviews, infra-reviews+recipes-py_chromium.org

Target Ref:
refs/heads/master

Project:
recipe_engine

Visibility:
Public.

More Reviews

Description

Add logging to fetch, retry if gitiles gives us weird unicode BUG=649466

Patch Set 2 : Add logging for gitiles. #

Total comments: 1

Created: 4 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+25 lines, -5 lines)			Patch
	M	recipe_engine/fetch.py	View	1	4 chunks	+25 lines, -5 lines	1 comment	Download

Messages

Total messages: 6 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

martiniss

https://codereview.chromium.org/2365693002/diff/20001/recipe_engine/fetch.py File recipe_engine/fetch.py (right): https://codereview.chromium.org/2365693002/diff/20001/recipe_engine/fetch.py#newcode299 recipe_engine/fetch.py:299: raise FetchError( A (maybe unfounded) hypothesis is that the ...

4 years, 3 months ago (2016-09-23 00:42:59 UTC) #3

dnj

Ack I did my own version of this: https://codereview.chromium.org/2362993002/ after the trooper meeting.

4 years, 3 months ago (2016-09-23 00:43:43 UTC) #5