|
|
Created:
4 years, 2 months ago by Bence Modified:
4 years, 2 months ago Reviewers:
Ryan Hamilton CC:
chromium-reviews, cbentzel+watch_chromium.org Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionAdd support for zero-copy transfer of unchanged bytes.
This CL lands server change 133740552 by agt.
BUG=488484
Committed: https://crrev.com/d2bafaa1062d386e430bd925c2d6be34ed98f30b
Cr-Commit-Position: refs/heads/master@{#420737}
Patch Set 1 #
Messages
Total messages: 21 (9 generated)
bnc@chromium.org changed reviewers: + rch@chromium.org
Ryan: PTAL. This is dead code, do we need to merge it?
On 2016/09/22 19:55:03, Bence wrote: > Ryan: PTAL. This is dead code, do we need to merge it? What does dead code mean here? In any case, yes, we should keep this file in sync as much as possible to avoid friction later, imho. LGTM
The CQ bit was checked by bnc@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
On 2016/09/22 21:47:26, Ryan Hamilton wrote: > On 2016/09/22 19:55:03, Bence wrote: > > Ryan: PTAL. This is dead code, do we need to merge it? > > What does dead code mean here? In any case, yes, we should keep this file in > sync as much as possible to avoid friction later, imho. > > LGTM Thanks. By dead code I mean that SpdySerializedFrame::ReleaseBuffer() is never called in Chromium.
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: win_clang on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_clang/builds/...)
The CQ bit was checked by bnc@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
The CQ bit was checked by bnc@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: win_clang on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_clang/builds/...)
The CQ bit was checked by bnc@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== Add support for zero-copy transfer of unchanged bytes. This CL lands server change 133740552 by agt. BUG=488484 ========== to ========== Add support for zero-copy transfer of unchanged bytes. This CL lands server change 133740552 by agt. BUG=488484 Committed: https://crrev.com/d2bafaa1062d386e430bd925c2d6be34ed98f30b Cr-Commit-Position: refs/heads/master@{#420737} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/d2bafaa1062d386e430bd925c2d6be34ed98f30b Cr-Commit-Position: refs/heads/master@{#420737} |