Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(104)

Issue 2365663002: Fix infinite loop when calling GrowNamedColorList (Closed)

Created:
4 years, 3 months ago by kcwu
Modified:
4 years, 3 months ago
Reviewers:
Tom Sepez
CC:
pdfium-reviews_googlegroups.com
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Fix infinite loop when calling GrowNamedColorList Handle the case that GrowNamedColorList return fail when list is too long. Otherwise the loop never ends. Found by libfuzzer Committed: https://pdfium.googlesource.com/pdfium/+/869a4381b12dadfabe9750bd4d1a3867241917c8

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+47 lines, -4 lines) Patch
A third_party/lcms2-2.6/0002-infinite-loop-GrowNamedColorList.patch View 1 chunk +34 lines, -0 lines 0 comments Download
M third_party/lcms2-2.6/README.pdfium View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/lcms2-2.6/src/cmsnamed.c View 2 chunks +12 lines, -4 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
kcwu
PTAL I will upstream later
4 years, 3 months ago (2016-09-22 18:23:59 UTC) #2
Tom Sepez
lgtm
4 years, 3 months ago (2016-09-22 18:30:17 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2365663002/1
4 years, 3 months ago (2016-09-22 18:32:20 UTC) #5
commit-bot: I haz the power
4 years, 3 months ago (2016-09-22 18:45:53 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://pdfium.googlesource.com/pdfium/+/869a4381b12dadfabe9750bd4d1a38672419...

Powered by Google App Engine
This is Rietveld 408576698