Chromium Code Reviews| OLD | NEW |
|---|---|
| 1 // Copyright 2016 The Chromium Authors. All rights reserved. | 1 // Copyright 2016 The Chromium Authors. All rights reserved. |
| 2 // Use of this source code is governed by a BSD-style license that can be | 2 // Use of this source code is governed by a BSD-style license that can be |
| 3 // found in the LICENSE file. | 3 // found in the LICENSE file. |
| 4 | 4 |
| 5 package org.chromium.chrome.browser.contextualsearch; | 5 package org.chromium.chrome.browser.contextualsearch; |
| 6 | 6 |
| 7 /** | 7 /** |
| 8 * A piece of conditional behavior that supports experimentation and logging. | 8 * A piece of conditional behavior that supports experimentation and logging. |
| 9 */ | 9 */ |
| 10 abstract class ContextualSearchHeuristic { | 10 abstract class ContextualSearchHeuristic { |
| (...skipping 26 matching lines...) Expand all Loading... | |
| 37 | 37 |
| 38 /** | 38 /** |
| 39 * @return Whether this heuristic should be considered when logging aggregat e metrics for Tap | 39 * @return Whether this heuristic should be considered when logging aggregat e metrics for Tap |
| 40 * suppression. | 40 * suppression. |
| 41 */ | 41 */ |
| 42 protected boolean shouldAggregateLogForTapSuppression() { | 42 protected boolean shouldAggregateLogForTapSuppression() { |
| 43 return true; | 43 return true; |
| 44 } | 44 } |
| 45 | 45 |
| 46 /** | 46 /** |
| 47 * @return Whether this heuristic's condition would have been satisfied if i t were enabled | 47 * @return Whether this heuristic's condition would have been satisfied, cau sing a tap |
| 48 * through VariationsAssociatedData. When logging aggregate metrics for Tap suppression, | 48 * suppression, if it were enabled through VariationsAssociatedData. This method should |
| 49 * the condition may be considered satisfied even if the tap wasn't suppresed. | 49 * return false if the feature is enabled through VariationsAssociat edData. |
|
Donn Denman
2016/09/23 20:40:13
Nit: please rephrase this second sentence to bette
Theresa
2016/09/23 20:57:30
Done.
| |
| 50 */ | 50 */ |
| 51 protected abstract boolean isConditionSatisfiedForAggregateLogging(); | 51 protected abstract boolean isConditionSatisfiedForAggregateLogging(); |
| 52 } | 52 } |
| OLD | NEW |