Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2365653006:
Address review nits from r420647 (Closed)
|
Created:
4 years, 3 months ago by wolenetz Modified:
4 years, 2 months ago Reviewers:
chcunningham CC:
chromium-reviews, feature-media-reviews_chromium.org Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionAddress review nits from r420647
https://codereview.chromium.org/2361903002/ landed with an unreviewed
patchset containing a typo. This change fixes that typo and
opportunistically removes an unused field, both in MP4StreamParser.
R=chcunningham@chromium.org
Committed: https://crrev.com/55eeed717beb9d276318dc3ccc0d3b401b03df70
Cr-Commit-Position: refs/heads/master@{#420827}
Patch Set 1 #
Total comments: 1
Patch Set 2 : Fix typo in header #
Messages
Total messages: 22 (13 generated)
The CQ bit was checked by wolenetz@chromium.org to run a CQ dry run
Please take a look. Thanks!
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Oops: https://codereview.chromium.org/2365653006/diff/1/media/formats/mp4/mp4_strea... File media/formats/mp4/mp4_stream_parser.h (right): https://codereview.chromium.org/2365653006/diff/1/media/formats/mp4/mp4_strea... media/formats/mp4/mp4_stream_parser.h:129: int num_emtpy_samples_skipped_; ugh. I'll fix this in next patch set...
The CQ bit was unchecked by wolenetz@chromium.org
The CQ bit was checked by wolenetz@chromium.org to run a CQ dry run
OK. Patch set 2 is ready for review. Please CQ it if it LGTY.
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
chcunningham@chromium.org changed reviewers: + chcunningham@chromium.org - chunningham@chromium.org
LGTM.
Description was changed from ========== Address review nits from r420647 https://codereview.chromium.org/2361903002/ landed with an unreviewed patchset containing a typo. This change fixes that typo and opportunistically removes an unused field, both in MP4StreamParser. R=chunningham@chromium.org ========== to ========== Address review nits from r420647 https://codereview.chromium.org/2361903002/ landed with an unreviewed patchset containing a typo. This change fixes that typo and opportunistically removes an unused field, both in MP4StreamParser. R=chcunningham@chromium.org ==========
The CQ bit was unchecked by wolenetz@chromium.org
The CQ bit was checked by wolenetz@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
The CQ bit was checked by wolenetz@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Address review nits from r420647 https://codereview.chromium.org/2361903002/ landed with an unreviewed patchset containing a typo. This change fixes that typo and opportunistically removes an unused field, both in MP4StreamParser. R=chcunningham@chromium.org ========== to ========== Address review nits from r420647 https://codereview.chromium.org/2361903002/ landed with an unreviewed patchset containing a typo. This change fixes that typo and opportunistically removes an unused field, both in MP4StreamParser. R=chcunningham@chromium.org ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== Address review nits from r420647 https://codereview.chromium.org/2361903002/ landed with an unreviewed patchset containing a typo. This change fixes that typo and opportunistically removes an unused field, both in MP4StreamParser. R=chcunningham@chromium.org ========== to ========== Address review nits from r420647 https://codereview.chromium.org/2361903002/ landed with an unreviewed patchset containing a typo. This change fixes that typo and opportunistically removes an unused field, both in MP4StreamParser. R=chcunningham@chromium.org Committed: https://crrev.com/55eeed717beb9d276318dc3ccc0d3b401b03df70 Cr-Commit-Position: refs/heads/master@{#420827} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/55eeed717beb9d276318dc3ccc0d3b401b03df70 Cr-Commit-Position: refs/heads/master@{#420827} |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
