Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Issue 2365633002: [wasm] Make sure the interpreter only executes preprocessed code. (Closed)

Created:
4 years, 3 months ago by ahaas
Modified:
4 years, 3 months ago
Reviewers:
titzer
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[wasm] Make sure the interpreter only executes preprocessed code. BUG=chromium:646753 R=titzer@chromium.org Committed: https://crrev.com/813be427913c8506d78184be2a59d70dc42b9f00 Cr-Commit-Position: refs/heads/master@{#39638}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Preprocess at the right place #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M src/wasm/wasm-interpreter.cc View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 15 (8 generated)
ahaas
4 years, 3 months ago (2016-09-22 14:15:53 UTC) #1
titzer
https://codereview.chromium.org/2365633002/diff/1/src/wasm/wasm-interpreter.cc File src/wasm/wasm-interpreter.cc (right): https://codereview.chromium.org/2365633002/diff/1/src/wasm/wasm-interpreter.cc#newcode1039 src/wasm/wasm-interpreter.cc:1039: Execute(codemap()->Preprocess(frames_.back().code), Maybe PushFrame should do this?
4 years, 3 months ago (2016-09-22 14:18:24 UTC) #4
ahaas
https://codereview.chromium.org/2365633002/diff/1/src/wasm/wasm-interpreter.cc File src/wasm/wasm-interpreter.cc (right): https://codereview.chromium.org/2365633002/diff/1/src/wasm/wasm-interpreter.cc#newcode1039 src/wasm/wasm-interpreter.cc:1039: Execute(codemap()->Preprocess(frames_.back().code), On 2016/09/22 at 14:18:24, titzer wrote: > Maybe ...
4 years, 3 months ago (2016-09-22 14:40:37 UTC) #7
titzer
lgtm
4 years, 3 months ago (2016-09-22 15:45:13 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2365633002/20001
4 years, 3 months ago (2016-09-22 17:08:23 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 3 months ago (2016-09-22 17:11:45 UTC) #13
commit-bot: I haz the power
4 years, 3 months ago (2016-09-22 17:12:00 UTC) #15
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/813be427913c8506d78184be2a59d70dc42b9f00
Cr-Commit-Position: refs/heads/master@{#39638}

Powered by Google App Engine
This is Rietveld 408576698