Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(116)

Issue 2365623003: Remove unused thread.h include in trace_event_impl.h and fix IWUU. (Closed)

Created:
4 years, 3 months ago by gab
Modified:
4 years, 2 months ago
CC:
Aaron Boodman, abarth-chromium, chromium-reviews, darin (slow to review), feature-media-reviews_chromium.org, piman+watch_chromium.org, posciak+watch_chromium.org, qsr+mojo_chromium.org, tracing+reviews_chromium.org, viettrungluu+watch_chromium.org, wfh+watch_chromium.org, yzshen+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove unneeded thread.h includes and fix IWUU. Include removed from trace_event_impl.h and leveldb_mojo_proxy.h Removing unnecessary thread.h includes allows including trace_event_impl.h in pending_task.h without introducing a cyclic dependency (in a follow-up CL). BUG=649084 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel TBR=wez,pastarmovj,rockot,sadrul (ref. https://codereview.chromium.org/2365623003/#msg68) Committed: https://crrev.com/4d92485f89ba1de9d4e4f0f37789a0055e19daae Cr-Commit-Position: refs/heads/master@{#420989}

Patch Set 1 #

Patch Set 2 : Many more related IWUU fixes #

Patch Set 3 : Even more IWUU fixes :-O..! #

Patch Set 4 : ... and more! #

Patch Set 5 : <list> include belongs in render_message_filter.h not .cc #

Patch Set 6 : rebase onto r420823 #

Patch Set 7 : and more... #

Patch Set 8 : one more... #

Patch Set 9 : hack WebKit test DEPS #

Patch Set 10 : Whitelist base DEPS for all web/tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -8 lines) Patch
M base/threading/sequenced_worker_pool.cc View 1 chunk +1 line, -0 lines 0 comments Download
M base/trace_event/trace_event_android.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M base/trace_event/trace_event_impl.h View 1 chunk +0 lines, -1 line 0 comments Download
M base/trace_event/trace_log.cc View 1 chunk +1 line, -0 lines 0 comments Download
M blimp/client/core/compositor/blimp_compositor_frame_sink_unittest.cc View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M blimp/client/core/compositor/blimp_compositor_unittest.cc View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M cc/raster/raster_buffer_provider_unittest.cc View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M cc/test/fake_external_begin_frame_source.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M cc/tiles/picture_layer_tiling_set.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M cc/trees/remote_channel_impl.h View 1 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/safe_browsing/protocol_manager_unittest.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M components/leveldb/leveldb_mojo_proxy.h View 1 chunk +4 lines, -1 line 0 comments Download
M components/leveldb/leveldb_mojo_proxy.cc View 1 chunk +1 line, -0 lines 0 comments Download
M components/policy/core/common/cloud/policy_header_io_helper_unittest.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M components/policy/core/common/cloud/policy_header_service_unittest.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/gpu/gpu_process_host.h View 1 2 1 chunk +4 lines, -0 lines 0 comments Download
M content/browser/renderer_host/render_message_filter.h View 1 2 3 4 5 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/renderer_host/render_message_filter.cc View 1 2 3 4 5 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/tracing/background_tracing_config_unittest.cc View 1 2 3 4 5 6 1 chunk +1 line, -0 lines 0 comments Download
M content/renderer/media/audio_renderer_sink_cache_unittest.cc View 1 2 3 4 5 6 1 chunk +1 line, -0 lines 0 comments Download
M extensions/browser/api/display_source/display_source_apitestbase.cc View 1 2 3 4 5 6 7 1 chunk +1 line, -0 lines 0 comments Download
M ipc/attachment_broker_mac_unittest.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M ipc/ipc_send_fds_test.cc View 1 2 3 4 5 1 chunk +1 line, -0 lines 0 comments Download
M ipc/ipc_test_channel_listener.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M media/cast/test/end2end_unittest.cc View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M media/gpu/android_video_decode_accelerator.cc View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/web/tests/DEPS View 1 2 3 4 5 6 7 8 9 1 chunk +1 line, -6 lines 0 comments Download
M third_party/WebKit/Source/web/tests/TimerPerfTest.cpp View 1 2 3 4 5 6 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/web/tests/VirtualTimeTest.cpp View 1 2 3 4 5 6 1 chunk +1 line, -0 lines 0 comments Download
M ui/events/ozone/device/udev/device_manager_udev.cc View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M ui/gl/gl_context_cgl.cc View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M ui/ozone/public/ozone_gpu_test_helper.cc View 1 2 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 80 (57 generated)
gab
oysteine PTAL at whole CL as owner of base/trace_event TBR: - danakj for base/ side-effects ...
4 years, 3 months ago (2016-09-22 20:33:14 UTC) #4
DaleCurtis
media/ lgtm
4 years, 3 months ago (2016-09-22 20:34:06 UTC) #7
danakj
LGTM
4 years, 3 months ago (2016-09-22 20:35:25 UTC) #8
Elliot Glaysher
lgtm
4 years, 3 months ago (2016-09-22 20:37:22 UTC) #9
oystein (OOO til 10th of July)
lgtm
4 years, 3 months ago (2016-09-22 20:47:40 UTC) #10
gab
TBR for more IWUU fixes falling out of this: @oystein: base/trace_event/trace_event_android.cc @danakj: cc/test/fake_external_begin_frame_source.h cc/tiles/picture_layer_tiling_set.h cc/trees/remote_channel_impl.h ...
4 years, 3 months ago (2016-09-23 17:32:08 UTC) #17
mattm
safe_browsing lgtm
4 years, 3 months ago (2016-09-23 18:01:30 UTC) #20
gab
On 2016/09/23 17:32:08, gab wrote: > TBR for more IWUU fixes falling out of this: ...
4 years, 3 months ago (2016-09-23 18:51:32 UTC) #26
gab
On 2016/09/23 18:51:32, gab wrote: > On 2016/09/23 17:32:08, gab wrote: > > TBR for ...
4 years, 3 months ago (2016-09-23 19:24:32 UTC) #32
hubbe
media/cast/test/end2end_unittest.cc LGTM
4 years, 3 months ago (2016-09-23 19:27:14 UTC) #33
ncarter (slow)
content/ lgtm
4 years, 3 months ago (2016-09-23 19:48:53 UTC) #34
gab
Left to review: @esprehn (this currently breaks DEPS presubmit... what's the right thing to do ...
4 years, 2 months ago (2016-09-24 13:16:26 UTC) #55
esprehn
Hmm you're not really supposed to include base in web, but I see this is ...
4 years, 2 months ago (2016-09-24 14:10:12 UTC) #58
gab
On 2016/09/24 14:10:12, esprehn wrote: > Hmm you're not really supposed to include base in ...
4 years, 2 months ago (2016-09-26 13:55:14 UTC) #63
gab
On 2016/09/26 13:55:14, gab wrote: > On 2016/09/24 14:10:12, esprehn wrote: > > Hmm you're ...
4 years, 2 months ago (2016-09-26 19:38:32 UTC) #66
esprehn
lgtm
4 years, 2 months ago (2016-09-26 20:48:37 UTC) #67
gab
A few TBRs for other benign IWUU: @wez: blimp/client/core/compositor/blimp_compositor_frame_sink_unittest.cc blimp/client/core/compositor/blimp_compositor_unittest.cc @pastarmovj: components/policy/core/common/cloud/policy_header_io_helper_unittest.cc components/policy/core/common/cloud/policy_header_service_unittest.cc @rockot: extensions/browser/api/display_source/display_source_apitestbase.cc ...
4 years, 2 months ago (2016-09-26 20:51:12 UTC) #68
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2365623003/240001
4 years, 2 months ago (2016-09-26 20:53:13 UTC) #73
commit-bot: I haz the power
Committed patchset #10 (id:240001)
4 years, 2 months ago (2016-09-26 21:01:09 UTC) #75
commit-bot: I haz the power
Patchset 10 (id:??) landed as https://crrev.com/4d92485f89ba1de9d4e4f0f37789a0055e19daae Cr-Commit-Position: refs/heads/master@{#420989}
4 years, 2 months ago (2016-09-26 21:04:25 UTC) #77
sadrul
lgtm
4 years, 2 months ago (2016-09-27 04:01:52 UTC) #78
Wez
blimp/ LGTM
4 years, 2 months ago (2016-10-08 01:21:15 UTC) #79
pastarmovj
4 years, 2 months ago (2016-10-10 09:59:19 UTC) #80
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698