Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(239)

Issue 2365613002: predictors: Refactor the prefetcher in resource_prefetch_predictor. (Closed)

Created:
4 years, 3 months ago by Benoit L
Modified:
4 years, 3 months ago
Reviewers:
pasko
CC:
chromium-reviews, shishir+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

predictors: Refactor the prefetcher in resource_prefetch_predictor. The status is no longer reported through UMA, removing the plumbing makes it easier to evolve. BUG=631966 Committed: https://crrev.com/3dfb4a29d8602e3c5dbb09fa8fc50412ad2d2cba Cr-Commit-Position: refs/heads/master@{#420340}

Patch Set 1 #

Patch Set 2 : . #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+94 lines, -354 lines) Patch
M chrome/browser/predictors/resource_prefetch_predictor.h View 6 chunks +4 lines, -47 lines 0 comments Download
M chrome/browser/predictors/resource_prefetch_predictor.cc View 8 chunks +13 lines, -55 lines 2 comments Download
M chrome/browser/predictors/resource_prefetcher.h View 4 chunks +10 lines, -49 lines 0 comments Download
M chrome/browser/predictors/resource_prefetcher.cc View 7 chunks +26 lines, -50 lines 0 comments Download
M chrome/browser/predictors/resource_prefetcher_manager.h View 2 chunks +4 lines, -13 lines 0 comments Download
M chrome/browser/predictors/resource_prefetcher_manager.cc View 4 chunks +4 lines, -28 lines 0 comments Download
M chrome/browser/predictors/resource_prefetcher_unittest.cc View 1 8 chunks +33 lines, -112 lines 0 comments Download

Messages

Total messages: 13 (7 generated)
Benoit L
4 years, 3 months ago (2016-09-22 13:13:10 UTC) #2
pasko
lgtm https://codereview.chromium.org/2365613002/diff/20001/chrome/browser/predictors/resource_prefetch_predictor.cc File chrome/browser/predictors/resource_prefetch_predictor.cc (left): https://codereview.chromium.org/2365613002/diff/20001/chrome/browser/predictors/resource_prefetch_predictor.cc#oldcode542 chrome/browser/predictors/resource_prefetch_predictor.cc:542: return true; why is this early return removed? ...
4 years, 3 months ago (2016-09-22 13:21:05 UTC) #3
Benoit L
Thanks! https://codereview.chromium.org/2365613002/diff/20001/chrome/browser/predictors/resource_prefetch_predictor.cc File chrome/browser/predictors/resource_prefetch_predictor.cc (left): https://codereview.chromium.org/2365613002/diff/20001/chrome/browser/predictors/resource_prefetch_predictor.cc#oldcode542 chrome/browser/predictors/resource_prefetch_predictor.cc:542: return true; On 2016/09/22 13:21:05, pasko wrote: > ...
4 years, 3 months ago (2016-09-22 14:42:50 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2365613002/20001
4 years, 3 months ago (2016-09-22 14:56:42 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 3 months ago (2016-09-22 15:04:24 UTC) #11
commit-bot: I haz the power
4 years, 3 months ago (2016-09-22 15:06:28 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/3dfb4a29d8602e3c5dbb09fa8fc50412ad2d2cba
Cr-Commit-Position: refs/heads/master@{#420340}

Powered by Google App Engine
This is Rietveld 408576698