predictors: Refactor the prefetcher in resource_prefetch_predictor.

predictors: Refactor the prefetcher in resource_prefetch_predictor.

The status is no longer reported through UMA, removing the plumbing
makes it easier to evolve.

BUG=631966
Committed: https://crrev.com/3dfb4a29d8602e3c5dbb09fa8fc50412ad2d2cba
Cr-Commit-Position: refs/heads/master@{#420340}

[Benoit L, 2016-09-22 13:13:09]

lizeb@chromium.org changed reviewers:
+ pasko@chromium.org

[pasko, 2016-09-22 13:21:05]

lgtm

https://codereview.chromium.org/2365613002/diff/20001/chrome/browser/predicto...
File chrome/browser/predictors/resource_prefetch_predictor.cc (left):

https://codereview.chromium.org/2365613002/diff/20001/chrome/browser/predicto...
chrome/browser/predictors/resource_prefetch_predictor.cc:542: return true;
why is this early return removed? guaranteed to be non-empty? DCHECK?

[Benoit L, 2016-09-22 13:33:17]

The CQ bit was checked by lizeb@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-22 13:33:47]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Benoit L, 2016-09-22 14:42:50]

Thanks!

https://codereview.chromium.org/2365613002/diff/20001/chrome/browser/predicto...
File chrome/browser/predictors/resource_prefetch_predictor.cc (left):

https://codereview.chromium.org/2365613002/diff/20001/chrome/browser/predicto...
chrome/browser/predictors/resource_prefetch_predictor.cc:542: return true;
On 2016/09/22 13:21:05, pasko wrote:
> why is this early return removed? guaranteed to be non-empty? DCHECK?

No, but the return re-arrangement is equivalent. Just less code.

[commit-bot: I haz the power, 2016-09-22 14:54:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-22 14:54:25]

Dry run: This issue passed the CQ dry run.

[Benoit L, 2016-09-22 14:56:13]

The CQ bit was checked by lizeb@chromium.org

[commit-bot: I haz the power, 2016-09-22 14:56:42]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-22 15:04:24]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-09-22 15:06:27]

Description was changed from

==========
predictors: Refactor the prefetcher in resource_prefetch_predictor.

The status is no longer reported through UMA, removing the plumbing
makes it easier to evolve.

BUG=631966
==========

to

==========
predictors: Refactor the prefetcher in resource_prefetch_predictor.

The status is no longer reported through UMA, removing the plumbing
makes it easier to evolve.

BUG=631966

Committed: https://crrev.com/3dfb4a29d8602e3c5dbb09fa8fc50412ad2d2cba
Cr-Commit-Position: refs/heads/master@{#420340}
==========

[commit-bot: I haz the power, 2016-09-22 15:06:28]

Patchset 2 (id:??) landed as
https://crrev.com/3dfb4a29d8602e3c5dbb09fa8fc50412ad2d2cba
Cr-Commit-Position: refs/heads/master@{#420340}