Issue 23656004: Cross-compiling from Linux to Android requires -lrt for the host toolset.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 23656004: Cross-compiling from Linux to Android requires -lrt for the host toolset. (Closed)

Created:
7 years, 3 months ago by Benedikt Meurer

Modified:
7 years, 3 months ago

Reviewers:
yurys, Michael Achenbach

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Cross-compiling from Linux to Android requires -lrt for the host toolset. R=yurys@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=16402

Patch Set 1 #

Total comments: 2

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+9 lines, -0 lines)			Patch
	M	tools/gyp/v8.gyp	View		1 chunk	+9 lines, -0 lines	2 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Benedikt Meurer

Hey Michael, Here's a build fix for the android cross-compiler. PTAL -- Benedikt

7 years, 3 months ago (2013-08-28 13:58:57 UTC) #1

yurys

https://codereview.chromium.org/23656004/diff/1/tools/gyp/v8.gyp File tools/gyp/v8.gyp (right): https://codereview.chromium.org/23656004/diff/1/tools/gyp/v8.gyp#newcode726 tools/gyp/v8.gyp:726: 'target_conditions': [ Will it work on Mac OS X?

7 years, 3 months ago (2013-08-28 14:08:34 UTC) #2

Benedikt Meurer

7 years, 3 months ago (2013-08-28 14:10:07 UTC) #3

Benedikt Meurer

7 years, 3 months ago (2013-08-28 14:11:14 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 manually as r16402 (presubmit successful).

Expand Messages | Collapse Messages