Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(482)

Issue 2365583004: Mac: Clean up plumbing of accelerated widgets (Closed)

Created:
4 years, 3 months ago by ccameron
Modified:
4 years, 3 months ago
Reviewers:
Zhenyao Mo, dcheng, piman
CC:
chromium-reviews, jam, sievers+watch_chromium.org, jbauman+watch_chromium.org, darin-cc_chromium.org, piman+watch_chromium.org, kalyank, danakj+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Mac: Clean up plumbing of accelerated widgets Don't plumb through the surface handle of swaps and use it to look up the AcceleratedWidgetMac. Just use it directly (since it's available at construction time). BUG= CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Committed: https://crrev.com/6dfd3f396e30d2055e640e4a1f94fd059a0e10dd Cr-Commit-Position: refs/heads/master@{#420765}

Patch Set 1 #

Total comments: 1

Patch Set 2 : Add explicit #

Total comments: 1

Patch Set 3 : make_scoped_refptr #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -34 lines) Patch
M content/browser/compositor/gpu_output_surface_mac.h View 2 chunks +5 lines, -0 lines 0 comments Download
M content/browser/compositor/gpu_output_surface_mac.mm View 4 chunks +4 lines, -3 lines 0 comments Download
M content/browser/compositor/gpu_process_transport_factory.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M gpu/ipc/client/command_buffer_proxy_impl.cc View 1 chunk +0 lines, -1 line 0 comments Download
M gpu/ipc/client/gpu_process_hosted_ca_layer_tree_params.h View 1 chunk +0 lines, -1 line 0 comments Download
M gpu/ipc/common/gpu_messages.h View 1 chunk +0 lines, -1 line 0 comments Download
M gpu/ipc/service/image_transport_surface_mac.mm View 1 2 4 chunks +5 lines, -9 lines 0 comments Download
M gpu/ipc/service/image_transport_surface_overlay_mac.h View 1 3 chunks +1 line, -4 lines 0 comments Download
M gpu/ipc/service/image_transport_surface_overlay_mac.mm View 4 chunks +2 lines, -13 lines 0 comments Download

Messages

Total messages: 18 (12 generated)
ccameron
Plumbing cleaning ...
4 years, 3 months ago (2016-09-23 00:51:50 UTC) #3
piman
drive-by LGTM + thanks https://codereview.chromium.org/2365583004/diff/1/gpu/ipc/service/image_transport_surface_overlay_mac.h File gpu/ipc/service/image_transport_surface_overlay_mac.h (right): https://codereview.chromium.org/2365583004/diff/1/gpu/ipc/service/image_transport_surface_overlay_mac.h#newcode38 gpu/ipc/service/image_transport_surface_overlay_mac.h:38: ImageTransportSurfaceOverlayMac(GpuCommandBufferStub* stub); nit: explicit
4 years, 3 months ago (2016-09-23 00:55:24 UTC) #5
dcheng
ipc lgtm! https://codereview.chromium.org/2365583004/diff/20001/gpu/ipc/service/image_transport_surface_mac.mm File gpu/ipc/service/image_transport_surface_mac.mm (right): https://codereview.chromium.org/2365583004/diff/20001/gpu/ipc/service/image_transport_surface_mac.mm#newcode54 gpu/ipc/service/image_transport_surface_mac.mm:54: return new ImageTransportSurfaceOverlayMac(stub); Nit: make_scoped_refptr
4 years, 3 months ago (2016-09-23 05:03:17 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2365583004/40001
4 years, 3 months ago (2016-09-23 20:24:09 UTC) #15
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 3 months ago (2016-09-23 22:55:30 UTC) #16
commit-bot: I haz the power
4 years, 3 months ago (2016-09-23 22:57:56 UTC) #18
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/6dfd3f396e30d2055e640e4a1f94fd059a0e10dd
Cr-Commit-Position: refs/heads/master@{#420765}

Powered by Google App Engine
This is Rietveld 408576698