Video Capture Device Win: cleanup error logging

Video Capture Device Win: cleanup error logging

While writing other code, I found out that the error logging
in VCDWin is cumbersome: it is too verbose on Init() and
doesn't dump the HRESULT while capturing.

So: This CL adds a macro DLOG_IF_WITH_HRESULT() that logs
an error message _and_ the stringified HRESULT. It also
sends an HRESULT to SetErrorMessage() to dump it on
stdout.

In my experience, all these loggings are only used
by developers to try and guess what goes wrong in Win
bots when those fail, so the less release code they take
up the better.

BUG=405016, 648490
Committed: https://crrev.com/63038c90b7a3419742d4c6781f47560a4dfb63f9
Cr-Commit-Position: refs/heads/master@{#420493}

[mcasas, 2016-09-22 19:26:52]

Description was changed from

==========
Experimental: less verbose VideoCaptureDeviceWin logs

BUG=
==========

to

==========
Video Capture Device Win: cleanup error logging

While writing other code, I found out that the error logging 
in VCDWin is cumbersome: it is too verbose on Init() and 
misses the HRESULT during allocate...stop. 

This CL adds a macro DLOG_IF_WITH_HRESULT() that logs
an error message _and_ the stringified HRESULT. It also 
sends an HRESULT to SetErrorMessage() to dump it on 
stdout.

In my experience, all these loggings are only used
by developers to try and guess what goes wrong in Win 
bots when those fail, so the less release code they take
up the better.

BUG=405016, 648490
==========

[mcasas, 2016-09-22 19:27:35]

Description was changed from

==========
Video Capture Device Win: cleanup error logging

While writing other code, I found out that the error logging 
in VCDWin is cumbersome: it is too verbose on Init() and 
misses the HRESULT during allocate...stop. 

This CL adds a macro DLOG_IF_WITH_HRESULT() that logs
an error message _and_ the stringified HRESULT. It also 
sends an HRESULT to SetErrorMessage() to dump it on 
stdout.

In my experience, all these loggings are only used
by developers to try and guess what goes wrong in Win 
bots when those fail, so the less release code they take
up the better.

BUG=405016, 648490
==========

to

==========
Video Capture Device Win: cleanup error logging

While writing other code, I found out that the error logging 
in VCDWin is cumbersome: it is too verbose on Init() and 
doesn't dump the HRESULT while capturing. 

So: This CL adds a macro DLOG_IF_WITH_HRESULT() that logs
an error message _and_ the stringified HRESULT. It also 
sends an HRESULT to SetErrorMessage() to dump it on 
stdout.

In my experience, all these loggings are only used
by developers to try and guess what goes wrong in Win 
bots when those fail, so the less release code they take
up the better.

BUG=405016, 648490
==========

[mcasas, 2016-09-22 19:29:27]

Patchset #1 (id:1) has been deleted

[mcasas, 2016-09-22 19:33:49]

mcasas@chromium.org changed reviewers:
+ xianglu@chromium.org

[mcasas, 2016-09-22 19:33:50]

xianglu@ PTAL

[mcasas, 2016-09-22 20:05:05]

Patchset #1 (id:20001) has been deleted

[mcasas, 2016-09-22 20:05:49]

Patchset #1 (id:40001) has been deleted

[xianglu, 2016-09-22 20:55:14]

lgtm. % one comment

https://codereview.chromium.org/2365533004/diff/60001/media/capture/video/win...
File media/capture/video/win/video_capture_device_win.cc (right):

https://codereview.chromium.org/2365533004/diff/60001/media/capture/video/win...
media/capture/video/win/video_capture_device_win.cc:28: #define
DLOG_IF_WITH_HRESULT(message, hr)                               \
Would it be better if named DLOG_IF_FAILED_WITH_HRESULT? Because you are only
checking this specific condition.

[mcasas, 2016-09-22 21:42:25]

The CQ bit was checked by mcasas@chromium.org

[mcasas, 2016-09-22 21:42:26]

The patchset sent to the CQ was uploaded after l-g-t-m from xianglu@chromium.org
Link to the patchset: https://codereview.chromium.org/2365533004/#ps80001
(title: "xianglu@ naming suggestion")

[commit-bot: I haz the power, 2016-09-22 21:42:56]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-22 23:09:32]

Description was changed from

==========
Video Capture Device Win: cleanup error logging

While writing other code, I found out that the error logging 
in VCDWin is cumbersome: it is too verbose on Init() and 
doesn't dump the HRESULT while capturing. 

So: This CL adds a macro DLOG_IF_WITH_HRESULT() that logs
an error message _and_ the stringified HRESULT. It also 
sends an HRESULT to SetErrorMessage() to dump it on 
stdout.

In my experience, all these loggings are only used
by developers to try and guess what goes wrong in Win 
bots when those fail, so the less release code they take
up the better.

BUG=405016, 648490
==========

to

==========
Video Capture Device Win: cleanup error logging

While writing other code, I found out that the error logging 
in VCDWin is cumbersome: it is too verbose on Init() and 
doesn't dump the HRESULT while capturing. 

So: This CL adds a macro DLOG_IF_WITH_HRESULT() that logs
an error message _and_ the stringified HRESULT. It also 
sends an HRESULT to SetErrorMessage() to dump it on 
stdout.

In my experience, all these loggings are only used
by developers to try and guess what goes wrong in Win 
bots when those fail, so the less release code they take
up the better.

BUG=405016, 648490
==========

[commit-bot: I haz the power, 2016-09-22 23:09:33]

Committed patchset #2 (id:80001)

[commit-bot: I haz the power, 2016-09-22 23:12:52]

Description was changed from

==========
Video Capture Device Win: cleanup error logging

While writing other code, I found out that the error logging 
in VCDWin is cumbersome: it is too verbose on Init() and 
doesn't dump the HRESULT while capturing. 

So: This CL adds a macro DLOG_IF_WITH_HRESULT() that logs
an error message _and_ the stringified HRESULT. It also 
sends an HRESULT to SetErrorMessage() to dump it on 
stdout.

In my experience, all these loggings are only used
by developers to try and guess what goes wrong in Win 
bots when those fail, so the less release code they take
up the better.

BUG=405016, 648490
==========

to

==========
Video Capture Device Win: cleanup error logging

While writing other code, I found out that the error logging
in VCDWin is cumbersome: it is too verbose on Init() and
doesn't dump the HRESULT while capturing.

So: This CL adds a macro DLOG_IF_WITH_HRESULT() that logs
an error message _and_ the stringified HRESULT. It also
sends an HRESULT to SetErrorMessage() to dump it on
stdout.

In my experience, all these loggings are only used
by developers to try and guess what goes wrong in Win
bots when those fail, so the less release code they take
up the better.

BUG=405016, 648490

Committed: https://crrev.com/63038c90b7a3419742d4c6781f47560a4dfb63f9
Cr-Commit-Position: refs/heads/master@{#420493}
==========

[commit-bot: I haz the power, 2016-09-22 23:12:53]

Patchset 2 (id:??) landed as
https://crrev.com/63038c90b7a3419742d4c6781f47560a4dfb63f9
Cr-Commit-Position: refs/heads/master@{#420493}