Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Issue 2365533003: Add WTF::Vector::emplaceAppend() (Closed)

Created:
4 years, 3 months ago by Mikhail
Modified:
4 years, 2 months ago
Reviewers:
tkent, Yuta Kitamura
CC:
chromium-reviews, blink-reviews, blink-reviews-wtf_chromium.org, Mikhail
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add WTF::Vector::emplaceAppend() The introduced 'emplaceAppend()' method provides more efficient code path when a new object instance requiring multiple constructor arguments is appended to a vector. Note: the existing 'append()' method is already implicitly emplacing new items for a single constructor argument case. Committed: https://crrev.com/489abbd8051308277f56f6878943a2f76d391d6d Cr-Commit-Position: refs/heads/master@{#420601}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -0 lines) Patch
M third_party/WebKit/Source/wtf/Vector.h View 2 chunks +18 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/wtf/VectorTest.cpp View 1 chunk +19 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
Mikhail
PTAL
4 years, 3 months ago (2016-09-22 15:24:53 UTC) #6
Yuta Kitamura
This method makes sense. LGTM
4 years, 2 months ago (2016-09-23 10:02:25 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2365533003/1
4 years, 2 months ago (2016-09-23 10:18:03 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-09-23 11:38:39 UTC) #10
commit-bot: I haz the power
4 years, 2 months ago (2016-09-23 11:40:50 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/489abbd8051308277f56f6878943a2f76d391d6d
Cr-Commit-Position: refs/heads/master@{#420601}

Powered by Google App Engine
This is Rietveld 408576698