Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(207)

Issue 2365533002: Add myself and boliu@ to browser android/ OWNERS. (Closed)

Created:
4 years, 3 months ago by aelias_OOO_until_Jul13
Modified:
4 years, 3 months ago
Reviewers:
Ted C
CC:
boliu, chromium-reviews, darin-cc_chromium.org, jam, jochen+watch_chromium.org, mlamouri+watch-content_chromium.org, Peter Beverloo, Yaron
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add myself and boliu@ to browser android/ OWNERS. boliu@ was added as content/browser OWNERS in https://codereview.chromium.org/2350213002/, but I observe this would still leaves a lot of incoming content/-related patches blocked on tedchoc@ or yfriedman@ review. Add us to these directories, which are either Android-specific C++ code, or Java code which interacts closely with C++. BUG= Committed: https://crrev.com/e0176316268aca2187d89f8576599ee8db0424db Cr-Commit-Position: refs/heads/master@{#420389}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -0 lines) Patch
M chrome/test/android/OWNERS View 1 chunk +2 lines, -0 lines 0 comments Download
M content/common/android/OWNERS View 1 chunk +2 lines, -0 lines 0 comments Download
M content/public/android/OWNERS View 1 chunk +2 lines, -0 lines 0 comments Download
M content/public/browser/android/OWNERS View 1 chunk +2 lines, -0 lines 0 comments Download
M content/public/test/android/OWNERS View 1 chunk +2 lines, -0 lines 0 comments Download
M content/shell/android/OWNERS View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
aelias_OOO_until_Jul13
Hi Ted, PTAL.
4 years, 3 months ago (2016-09-22 01:25:03 UTC) #2
Ted C
lgtm
4 years, 3 months ago (2016-09-22 16:45:38 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2365533002/1
4 years, 3 months ago (2016-09-22 17:39:40 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-22 17:51:36 UTC) #6
commit-bot: I haz the power
4 years, 3 months ago (2016-09-22 17:55:52 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e0176316268aca2187d89f8576599ee8db0424db
Cr-Commit-Position: refs/heads/master@{#420389}

Powered by Google App Engine
This is Rietveld 408576698