Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(141)

Issue 2365503003: cr-dialog scrollbar should span entire body (Closed)

Created:
4 years, 3 months ago by michaelpg
Modified:
4 years, 3 months ago
Reviewers:
dpapad
CC:
chromium-reviews, dbeam+watch-elements_chromium.org, michaelpg+watch-elements_chromium.org, oshima+watch_chromium.org, stevenjb+watch-md-settings_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

cr-dialog scrollbar should span entire body Use padding instead of margin; see bug for screeshots. BUG=649207 R=dpapad@chromium.org CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/b245b7d270fafab80c2eca0821a01165028b296d Cr-Commit-Position: refs/heads/master@{#420283}

Patch Set 1 #

Patch Set 2 : Vulcanized. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -2 lines) Patch
M chrome/browser/resources/md_downloads/vulcanized.html View 1 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/resources/md_history/app.vulcanized.html View 1 2 chunks +3 lines, -1 line 0 comments Download
M ui/webui/resources/cr_elements/cr_dialog/cr_dialog.html View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
michaelpg
As discussed.
4 years, 3 months ago (2016-09-22 01:16:03 UTC) #2
dpapad
LGTM
4 years, 3 months ago (2016-09-22 01:20:05 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2365503003/20001
4 years, 3 months ago (2016-09-22 07:49:37 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 3 months ago (2016-09-22 08:36:10 UTC) #6
commit-bot: I haz the power
4 years, 3 months ago (2016-09-22 08:38:01 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/b245b7d270fafab80c2eca0821a01165028b296d
Cr-Commit-Position: refs/heads/master@{#420283}

Powered by Google App Engine
This is Rietveld 408576698