Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(768)

Issue 2365493003: [wasm] Correctly handle the result of WasmModule::Instantiate in the wasm-module-runner (Closed)

Created:
4 years, 3 months ago by ahaas
Modified:
4 years, 3 months ago
Reviewers:
titzer
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[wasm] Correctly handle the result of WasmModule::Instantiate in the wasm-module-runner WasmModule::Instantiate can return an empty handle if it is not possible to instantiate the module. With this change the wasm-module-runner does not assume anymore that WasmModule::Instantiate produces a valid handle. BUG=chromium:648078 R=titzer@chromium.org Committed: https://crrev.com/447de9ae5b3ca027ec741147f7bc50de438d32f4 Cr-Commit-Position: refs/heads/master@{#39629}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -4 lines) Patch
M test/common/wasm/wasm-module-runner.cc View 1 chunk +8 lines, -4 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
ahaas
4 years, 3 months ago (2016-09-22 11:56:46 UTC) #1
titzer
lgtm
4 years, 3 months ago (2016-09-22 14:19:55 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2365493003/1
4 years, 3 months ago (2016-09-22 14:21:38 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-22 14:23:39 UTC) #9
commit-bot: I haz the power
4 years, 3 months ago (2016-09-22 14:23:54 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/447de9ae5b3ca027ec741147f7bc50de438d32f4
Cr-Commit-Position: refs/heads/master@{#39629}

Powered by Google App Engine
This is Rietveld 408576698