Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(75)

Issue 2365483002: Clean up dead code. (Closed)

Created:
4 years, 3 months ago by mtklein_C
Modified:
4 years, 3 months ago
Reviewers:
bsalomon, mtklein
CC:
reviews_skia.org
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Clean up dead code. SkOSEnvironment was used to set --enable-gl-path-rendering, and is now unused. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2365483002 Committed: https://skia.googlesource.com/skia/+/415a14d039b188ad5623c66225f47bfe73a2fb01

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -34 lines) Patch
M gyp/ports.gyp View 1 chunk +0 lines, -2 lines 0 comments Download
D src/ports/SkOSEnvironment.h View 1 chunk +0 lines, -13 lines 0 comments Download
D src/ports/SkOSEnvironment.cpp View 1 chunk +0 lines, -18 lines 0 comments Download
M tools/gpu/gl/command_buffer/GLTestContext_command_buffer.cpp View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 14 (10 generated)
mtklein_C
4 years, 3 months ago (2016-09-22 00:33:00 UTC) #7
bsalomon
lgtm
4 years, 3 months ago (2016-09-22 12:55:38 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2365483002/1
4 years, 3 months ago (2016-09-22 12:59:56 UTC) #12
commit-bot: I haz the power
4 years, 3 months ago (2016-09-22 13:01:20 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/415a14d039b188ad5623c66225f47bfe73a2fb01

Powered by Google App Engine
This is Rietveld 408576698