Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1019)

Issue 2365413002: Revert of [stubs] Port SubStringStub to TurboFan (Closed)

Created:
4 years, 2 months ago by Michael Hablich
Modified:
4 years, 2 months ago
CC:
v8-reviews_googlegroups.com, v8-mips-ports_googlegroups.com, v8-x87-ports_googlegroups.com, v8-ppc-ports_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of [stubs] Port SubStringStub to TurboFan (patchset #8 id:140001 of https://codereview.chromium.org/2355793003/ ) Reason for revert: Speculative revert because of stability problems Original issue's description: > [stubs] Port SubStringStub to TurboFan > > This ports the platform-specific SubStringStub to TurboFan. > > It also contains a minor bug-fix for the case when the requested substring > length equals the subject string length, but the start index is not equal to 0. > The old stub implementation returned the subject string, while the new > implementation calls into runtime, which finally results in a thrown exception. > > BUG=v8:5415 > > Committed: https://crrev.com/49be31921536716706a6790fbbf9c346b975af16 > Cr-Commit-Position: refs/heads/master@{#39653} TBR=ishell@chromium.org,bmeurer@chromium.org,jgruber@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=v8:5415, chromium:649967 NOPRESUBMIT=true NOTRY=true Committed: https://crrev.com/10a801f12bb9d482b5dcd4c5856ba7920cc8c72a Cr-Commit-Position: refs/heads/master@{#39737}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2045 lines, -417 lines) Patch
M src/arm/code-stubs-arm.cc View 1 chunk +225 lines, -0 lines 0 comments Download
M src/arm64/code-stubs-arm64.cc View 1 chunk +251 lines, -0 lines 0 comments Download
M src/code-stub-assembler.h View 5 chunks +1 line, -31 lines 0 comments Download
M src/code-stub-assembler.cc View 5 chunks +1 line, -360 lines 0 comments Download
M src/code-stubs.h View 1 chunk +5 lines, -16 lines 0 comments Download
M src/code-stubs.cc View 1 chunk +0 lines, -9 lines 0 comments Download
M src/full-codegen/full-codegen.cc View 1 chunk +0 lines, -1 line 0 comments Download
M src/ia32/code-stubs-ia32.cc View 1 chunk +221 lines, -0 lines 0 comments Download
M src/mips/code-stubs-mips.cc View 1 chunk +223 lines, -0 lines 0 comments Download
M src/mips64/code-stubs-mips64.cc View 1 chunk +223 lines, -0 lines 0 comments Download
M src/ppc/code-stubs-ppc.cc View 1 chunk +224 lines, -0 lines 0 comments Download
M src/s390/code-stubs-s390.cc View 1 chunk +229 lines, -0 lines 0 comments Download
M src/x64/code-stubs-x64.cc View 1 chunk +221 lines, -0 lines 0 comments Download
M src/x87/code-stubs-x87.cc View 1 chunk +221 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (7 generated)
Michael Hablich
Created Revert of [stubs] Port SubStringStub to TurboFan
4 years, 2 months ago (2016-09-26 14:32:06 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2365413002/1
4 years, 2 months ago (2016-09-26 14:32:17 UTC) #3
commit-bot: I haz the power
Try jobs failed on following builders: v8_presubmit on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/25002)
4 years, 2 months ago (2016-09-26 14:53:29 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2365413002/1
4 years, 2 months ago (2016-09-26 18:03:40 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-09-26 18:03:54 UTC) #11
commit-bot: I haz the power
4 years, 2 months ago (2016-09-26 18:04:13 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/10a801f12bb9d482b5dcd4c5856ba7920cc8c72a
Cr-Commit-Position: refs/heads/master@{#39737}

Powered by Google App Engine
This is Rietveld 408576698